fix(reward-lock): save removed txs in the consensus context#1092
Merged
fix(reward-lock): save removed txs in the consensus context#1092
Conversation
39f229d to
730437f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1092 +/- ##
==========================================
- Coverage 85.08% 85.00% -0.08%
==========================================
Files 314 314
Lines 23919 23922 +3
Branches 3614 3614
==========================================
- Hits 20351 20335 -16
- Misses 2863 2876 +13
- Partials 705 711 +6 ☔ View full report in Codecov by Sentry. |
1 task
jansegre
previously approved these changes
Jul 24, 2024
msbrogli
previously approved these changes
Jul 25, 2024
74be114 to
2ae57ca
Compare
jansegre
approved these changes
Jul 25, 2024
2 tasks
msbrogli
approved these changes
Jul 26, 2024
2ae57ca to
640b99d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1091
Motivation
When transactions get removed from the mempool after a reorg makes them invalid, their dependencies' metadata is updated. This update was being done directly in the storage, instead of in the consensus' context. This PR fixes this.
Acceptance Criteria
remove_transactions()from theTransactionStorageto theConsensus, as it is only used there and shouldn't be used anywhere else.contextargument and saves metadata through it instead of directly in the storage.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged