feat(event-queue): add new VERTEX_REMOVED event#1093
Merged
Conversation
glevco
force-pushed
the
feat/event-queue/add-tx-removed-event
branch
2 times, most recently
from
f878b8e to
6533408
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/reward-lock/update-context #1093 +/- ##
===============================================================
Coverage 84.83% 84.84%
===============================================================
Files 314 314
Lines 23903 23913 +10
Branches 3612 3613 +1
===============================================================
+ Hits 20278 20288 +10
Misses 2912 2912
Partials 713 713 ☔ View full report in Codecov by Sentry. |
msbrogli
previously approved these changes
Jul 25, 2024
glevco
force-pushed
the
fix/reward-lock/update-context
branch
2 times, most recently
from
74be114 to
2ae57ca
Compare
2 tasks
jansegre
previously approved these changes
Jul 26, 2024
glevco
force-pushed
the
fix/reward-lock/update-context
branch
from
2ae57ca to
640b99d
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
feat/event-queue/add-tx-removed-event
branch
from
6533408 to
a02ae1a
Compare
jansegre
approved these changes
Jul 26, 2024
msbrogli
approved these changes
Jul 26, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1092
Motivation
Even though the previous PR (#1092) fixes events so they include metadata updates for removed transaction dependencies, an event for the removed transaction itself was still missing. This PR adds it.
Acceptance Criteria
CONSENSUS_TX_REMOVEDevents so it happens afterCONSENSUS_TX_UPDATEevents.VERTEX_REMOVEDevent in the Event Queue.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged