tests(event-queue): add test for invalid tx in mempool#1091
Merged
Conversation
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 84.79% 84.77% -0.02%
==========================================
Files 314 314
Lines 23900 23900
Branches 3612 3612
==========================================
- Hits 20265 20262 -3
- Misses 2917 2921 +4
+ Partials 718 717 -1 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Jul 24, 2024
msbrogli
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
An Event Queue scenario simulation and its respective test was missing for the case where transactions get removed from the storage after a reorg.
Acceptance Criteria
INVALID_MEMPOOL_TRANSACTIONsimulation scenario and test.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged