refactor(side-dag): refactor node processes management#1079
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 85.07% 85.13% +0.05%
==========================================
Files 310 310
Lines 23558 23558
Branches 3561 3561
==========================================
+ Hits 20043 20057 +14
+ Misses 2808 2799 -9
+ Partials 707 702 -5 ☔ View full report in Codecov by Sentry. |
1 task
glevco
force-pushed
the
feat/side-dag/signers-validation
branch
from
54e6fa5 to
0abf019
Compare
glevco
force-pushed
the
refactor/side-dag/multiprocessing
branch
from
a801e48 to
12c0499
Compare
msbrogli
requested changes
Jul 5, 2024
jansegre
approved these changes
Jul 8, 2024
glevco
force-pushed
the
feat/side-dag/signers-validation
branch
from
0abf019 to
6868838
Compare
glevco
force-pushed
the
refactor/side-dag/multiprocessing
branch
5 times, most recently
from
02792c0 to
e965a13
Compare
msbrogli
previously approved these changes
Jul 12, 2024
jansegre
previously approved these changes
Jul 12, 2024
glevco
force-pushed
the
feat/side-dag/signers-validation
branch
from
b58b125 to
59a3dd9
Compare
glevco
force-pushed
the
refactor/side-dag/multiprocessing
branch
8 times, most recently
from
ee73bbf to
e140836
Compare
glevco
force-pushed
the
feat/side-dag/signers-validation
branch
2 times, most recently
from
244bb92 to
be45ae2
Compare
glevco
force-pushed
the
refactor/side-dag/multiprocessing
branch
from
e140836 to
81fd0ce
Compare
glevco
force-pushed
the
feat/side-dag/signers-validation
branch
from
be45ae2 to
75c5dba
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
refactor/side-dag/multiprocessing
branch
from
81fd0ce to
5e46ebd
Compare
jansegre
approved these changes
Jul 23, 2024
msbrogli
approved these changes
Jul 23, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1078
Motivation
Improve the
run_node_with_side_dagcommand so instead of a main process running the side dag node and a subprocess running the Hathor node, it's a main process running a monitor and multiple possible subprocesses running any number of nodes. For now, it only runs one side dag node and one Hathor node, but it can be easily changed to support more in the future.Resolves #1051.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged