Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
+ Coverage 84.90% 84.92% +0.02%
==========================================
Files 300 300
Lines 22936 22936
Branches 3471 3471
==========================================
+ Hits 19473 19479 +6
+ Misses 2774 2769 -5
+ Partials 689 688 -1 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Jun 17, 2024
jansegre
approved these changes
Jun 19, 2024
d3889b0 to
6cee55f
Compare
6cee55f to
d5d198b
Compare
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The new
run_node_with_side_dagcommand timed out in 10 seconds if the Hathor node did not start. This was incorrect because when loading from an existing storage, the Hathor node will always take more than 10 seconds to initialize.This PR removes the timeout and simply waits indefinitely until the Hathor node is either ready or errored. This will be further improved when the monitor process is implemented (see #1051).
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged