feat(side-dag): add signers validation on peer hello#1078
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
+ Coverage 84.93% 85.09% +0.16%
==========================================
Files 310 310
Lines 23524 23558 +34
Branches 3554 3561 +7
==========================================
+ Hits 19979 20047 +68
+ Misses 2839 2805 -34
Partials 706 706 ☔ View full report in Codecov by Sentry. |
1 task
jansegre
previously approved these changes
Jul 5, 2024
fe2945b to
4dc3e46
Compare
54e6fa5 to
0abf019
Compare
msbrogli
requested changes
Jul 5, 2024
4dc3e46 to
27f38be
Compare
0abf019 to
6868838
Compare
msbrogli
previously approved these changes
Jul 12, 2024
ad736ff to
12a05bd
Compare
b58b125 to
59a3dd9
Compare
26a1816 to
6bb8a4f
Compare
The base branch was changed.
59a3dd9 to
244bb92
Compare
msbrogli
previously approved these changes
Jul 22, 2024
244bb92 to
be45ae2
Compare
be45ae2 to
75c5dba
Compare
msbrogli
approved these changes
Jul 22, 2024
jansegre
approved these changes
Jul 22, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1075
Motivation
This PR adds a validation of PoA signers list when peers connect.
Acceptance Criteria
Builderso it requires settings to be set.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged