Skip to content

feat(side-dag): add ability to update signers list#1075

Merged
glevco merged 1 commit intomasterfrom
feat/side-dag/add-signers
Jul 22, 2024
Merged

feat(side-dag): add ability to update signers list#1075
glevco merged 1 commit intomasterfrom
feat/side-dag/add-signers

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 25, 2024

Depends on #1074

Motivation

Implement ability to update the signers list on PoA networks by configuring start and end block heights where each signer is active. By the default, a signer is active from height 0 to infinity. By setting the start height on a new signer, the network can coordinate to add it without disrupting existing blocks.

Acceptance Criteria

  • Update PoA settings to be able to configure start_height and end_height for signers.
  • Implement poa.get_active_signers() and update all usages of poa_settings.signers to use it instead.
  • Update PoaBlockProducer to calculate the signer index depending on active signers.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jun 25, 2024
@glevco glevco force-pushed the feat/side-dag/add-signers branch 3 times, most recently from 4fdf605 to b280c15 Compare June 26, 2024 15:30
@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (d30a59c) to head (6bb8a4f).

Files Patch % Lines
hathor/consensus/poa/poa_block_producer.py 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
- Coverage   84.96%   84.96%   -0.01%     
==========================================
  Files         310      310              
  Lines       23492    23524      +32     
  Branches     3548     3554       +6     
==========================================
+ Hits        19961    19986      +25     
- Misses       2828     2835       +7     
  Partials      703      703              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/side-dag/add-signers branch from b280c15 to fe2945b Compare June 26, 2024 16:18
@glevco glevco marked this pull request as ready for review June 26, 2024 16:24
@glevco glevco requested review from jansegre and msbrogli as code owners June 26, 2024 16:24
jansegre
jansegre previously approved these changes Jul 5, 2024
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from 57c3297 to f39ae23 Compare July 5, 2024 18:30
@glevco glevco force-pushed the feat/side-dag/add-signers branch from fe2945b to 4dc3e46 Compare July 5, 2024 18:32
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from f39ae23 to 2cf9bd8 Compare July 8, 2024 21:25
@glevco glevco force-pushed the feat/side-dag/add-signers branch from 4dc3e46 to 27f38be Compare July 8, 2024 21:26
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from 4ce9bf8 to 8de4838 Compare July 18, 2024 17:45
@glevco glevco force-pushed the feat/side-dag/add-signers branch from ad736ff to 12a05bd Compare July 18, 2024 18:08
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from 572fe0e to d152559 Compare July 18, 2024 20:41
@glevco glevco force-pushed the feat/side-dag/add-signers branch from 12a05bd to 83fb3d4 Compare July 18, 2024 20:42
msbrogli
msbrogli previously approved these changes Jul 22, 2024
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from d152559 to 6c026f4 Compare July 22, 2024 15:40
Base automatically changed from feat/side-dag/signer-round-robin to master July 22, 2024 16:49
@glevco glevco dismissed stale reviews from msbrogli and jansegre July 22, 2024 16:49

The base branch was changed.

@glevco glevco force-pushed the feat/side-dag/add-signers branch from 26a1816 to 6bb8a4f Compare July 22, 2024 17:09
@glevco glevco merged commit 0ded56d into master Jul 22, 2024
@glevco glevco deleted the feat/side-dag/add-signers branch July 22, 2024 18:52
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants