feat(side-dag): add ability to update signers list#1075
Merged
Conversation
4fdf605 to
b280c15
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
- Coverage 84.96% 84.96% -0.01%
==========================================
Files 310 310
Lines 23492 23524 +32
Branches 3548 3554 +6
==========================================
+ Hits 19961 19986 +25
- Misses 2828 2835 +7
Partials 703 703 ☔ View full report in Codecov by Sentry. |
b280c15 to
fe2945b
Compare
1 task
jansegre
previously approved these changes
Jul 5, 2024
57c3297 to
f39ae23
Compare
fe2945b to
4dc3e46
Compare
msbrogli
requested changes
Jul 5, 2024
f39ae23 to
2cf9bd8
Compare
4dc3e46 to
27f38be
Compare
4ce9bf8 to
8de4838
Compare
ad736ff to
12a05bd
Compare
572fe0e to
d152559
Compare
12a05bd to
83fb3d4
Compare
msbrogli
previously approved these changes
Jul 22, 2024
d152559 to
6c026f4
Compare
The base branch was changed.
26a1816 to
6bb8a4f
Compare
msbrogli
approved these changes
Jul 22, 2024
jansegre
approved these changes
Jul 22, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1074
Motivation
Implement ability to update the signers list on PoA networks by configuring start and end block heights where each signer is active. By the default, a signer is active from height 0 to infinity. By setting the start height on a new signer, the network can coordinate to add it without disrupting existing blocks.
Acceptance Criteria
start_heightandend_heightfor signers.poa.get_active_signers()and update all usages ofpoa_settings.signersto use it instead.PoaBlockProducerto calculate the signer index depending on active signers.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged