feat(side-dag): implement signer round-robin#1074
Merged
Conversation
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
==========================================
- Coverage 84.98% 84.98% -0.01%
==========================================
Files 310 310
Lines 23495 23492 -3
Branches 3549 3548 -1
==========================================
- Hits 19968 19964 -4
- Misses 2824 2825 +1
Partials 703 703 ☔ View full report in Codecov by Sentry. |
1 task
jansegre
previously approved these changes
Jul 5, 2024
6d715f6 to
e2b69ec
Compare
57c3297 to
f39ae23
Compare
msbrogli
requested changes
Jul 5, 2024
e2b69ec to
1579702
Compare
f39ae23 to
2cf9bd8
Compare
bbea340 to
fc3a749
Compare
4ce9bf8 to
8de4838
Compare
572fe0e to
d152559
Compare
msbrogli
approved these changes
Jul 22, 2024
jansegre
approved these changes
Jul 22, 2024
d152559 to
6c026f4
Compare
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1071
Motivation
Improve the mechanism used in
PoaBlockProducerto generate new block timestamps, as requested in #1061 (comment).Acceptance Criteria
poa.is_in_turn()topoa.in_turn_signer_index().PoaBlockProducertimestamp generation to use a signer round-robin approach instead of random delay.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged