Skip to content

feat(side-dag): implement signer round-robin#1074

Merged
glevco merged 1 commit intomasterfrom
feat/side-dag/signer-round-robin
Jul 22, 2024
Merged

feat(side-dag): implement signer round-robin#1074
glevco merged 1 commit intomasterfrom
feat/side-dag/signer-round-robin

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 24, 2024

Depends on #1071

Motivation

Improve the mechanism used in PoaBlockProducer to generate new block timestamps, as requested in #1061 (comment).

Acceptance Criteria

  • Change poa.is_in_turn() to poa.in_turn_signer_index().
  • Change PoaBlockProducer timestamp generation to use a signer round-robin approach instead of random delay.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jun 24, 2024
@glevco glevco marked this pull request as ready for review June 24, 2024 23:49
@glevco glevco requested review from jansegre and msbrogli as code owners June 24, 2024 23:49
@codecov
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (eb74c11) to head (6c026f4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
- Coverage   84.98%   84.98%   -0.01%     
==========================================
  Files         310      310              
  Lines       23495    23492       -3     
  Branches     3549     3548       -1     
==========================================
- Hits        19968    19964       -4     
- Misses       2824     2825       +1     
  Partials      703      703              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jansegre
jansegre previously approved these changes Jul 5, 2024
@glevco glevco force-pushed the feat/side-dag/apis branch from 6d715f6 to e2b69ec Compare July 5, 2024 18:20
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from 57c3297 to f39ae23 Compare July 5, 2024 18:30
@glevco glevco force-pushed the feat/side-dag/apis branch from e2b69ec to 1579702 Compare July 8, 2024 21:24
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from f39ae23 to 2cf9bd8 Compare July 8, 2024 21:25
@glevco glevco force-pushed the feat/side-dag/apis branch 3 times, most recently from bbea340 to fc3a749 Compare July 18, 2024 16:52
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from 4ce9bf8 to 8de4838 Compare July 18, 2024 17:45
Base automatically changed from feat/side-dag/apis to master July 18, 2024 19:04
@glevco glevco dismissed jansegre’s stale review July 18, 2024 19:04

The base branch was changed.

@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from 572fe0e to d152559 Compare July 18, 2024 20:41
@glevco glevco force-pushed the feat/side-dag/signer-round-robin branch from d152559 to 6c026f4 Compare July 22, 2024 15:40
@glevco glevco merged commit d30a59c into master Jul 22, 2024
@glevco glevco deleted the feat/side-dag/signer-round-robin branch July 22, 2024 16:49
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants