fix(cli): regression of --help after side-dag cli#1073
Merged
Conversation
glevco
approved these changes
Jun 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 84.88% 84.93% +0.04%
==========================================
Files 300 300
Lines 22944 22944
Branches 3471 3471
==========================================
+ Hits 19476 19487 +11
+ Misses 2777 2772 -5
+ Partials 691 685 -6 ☔ View full report in Codecov by Sentry. |
pedroferreira1
approved these changes
Jun 21, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #1039 using
python -m hathor run_node --helpshows an unrelated help display. This wasn't caught during review or by any tests. We should add tests for cli display in the future, although this PR only fixes the immediate problem.Acceptance Criteria
add_help=Falseto all the 3argparse.ArgumentParserintroduced in feat(side-dag): implement side_dag CLI command #1039 for partial parsingChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged