feat(side-dag): implement side_dag CLI command#1039
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 84.87% 84.95% +0.08%
==========================================
Files 300 300
Lines 22943 22943
Branches 3470 3470
==========================================
+ Hits 19473 19492 +19
+ Misses 2778 2766 -12
+ Partials 692 685 -7 ☔ View full report in Codecov by Sentry. |
3ad82a0 to
af8e08b
Compare
1 task
5bfc088 to
973afe6
Compare
msbrogli
requested changes
May 28, 2024
msbrogli
requested changes
May 29, 2024
e9121a7 to
bd05cd8
Compare
msbrogli
previously approved these changes
Jun 4, 2024
jansegre
reviewed
Jun 4, 2024
jansegre
reviewed
Jun 4, 2024
jansegre
reviewed
Jun 4, 2024
jansegre
previously approved these changes
Jun 7, 2024
jansegre
approved these changes
Jun 10, 2024
msbrogli
approved these changes
Jun 10, 2024
90a0606 to
2310be5
Compare
1 task
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1040
Motivation
Implement a new
side_dagCLI command that is able to run two independent full nodes, each in its own separate process. The command accepts the same options as therun_nodecommand, however options can be duplicate with a--side-dagprefix. Each full node is configured with the respective set of options. Processes are automatically terminated when one of the full nodes exits.Here's an example on how this command could be used:
$ python -m hathor side_dag --testnet --procname-prefix testnet- --memory-storage --disable-logs --side-dag-config-yaml ./my-side-dag.yml --side-dag-procname-prefix my-side-dag- --side-dag-memory-storage --side-dag-json-logsAcceptance Criteria
cli.util.process_logging_options().execute_from_command_line()so it supports modules opting out of thesetup_logging()call.create_parser()so it accepts a custom env var prefix.side_dagCLI command.HathorSettings.GENESIS_TOKENScalculated property, removing theGENESIS_TOKENSconstant.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged