Skip to content

fix(cli): regression of --help after side-dag cli #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansegre merged 1 commit into from
Jun 21, 2024
Merged

fix(cli): regression of --help after side-dag cli #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hathor/cli/side_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class LogOutputConfig(str, Enum):
SIDE_DAG = 'side-dag'
BOTH = 'both'

parser = argparse.ArgumentParser()
parser = argparse.ArgumentParser(add_help=False)
log_args = parser.add_mutually_exclusive_group()
log_args.add_argument('--json-logs', nargs='?', const='both', type=LogOutputConfig)
log_args.add_argument('--disable-logs', nargs='?', const='both', type=LogOutputConfig)
Expand Down
4 changes: 2 additions & 2 deletions hathor/cli/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class LoggingOptions(NamedTuple):

def process_logging_output(argv: list[str]) -> LoggingOutput:
"""Extract logging output before argv parsing."""
parser = argparse.ArgumentParser()
parser = argparse.ArgumentParser(add_help=False)

log_args = parser.add_mutually_exclusive_group()
log_args.add_argument('--json-logs', action='store_true')
Expand All @@ -158,7 +158,7 @@ def process_logging_output(argv: list[str]) -> LoggingOutput:

def process_logging_options(argv: list[str]) -> LoggingOptions:
"""Extract logging-specific options that are processed before argv parsing."""
parser = argparse.ArgumentParser()
parser = argparse.ArgumentParser(add_help=False)
parser.add_argument('--debug', action='store_true')

args, remaining_argv = parser.parse_known_args(argv)
Expand Down