feat(side-dag): implement gen_keys CLI command#1041
Merged
Conversation
glevco
force-pushed
the
feat/side-dag/key-cli
branch
from
bb8bd7a to
d770414
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 84.93% 84.93% -0.01%
==========================================
Files 300 300
Lines 22943 22943
Branches 3470 3470
==========================================
- Hits 19487 19486 -1
- Misses 2769 2771 +2
+ Partials 687 686 -1 ☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
May 28, 2024
glevco
force-pushed
the
feat/side-dag/cli
branch
2 times, most recently
from
e9121a7 to
bd05cd8
Compare
glevco
force-pushed
the
feat/side-dag/key-cli
branch
from
d770414 to
cc79770
Compare
glevco
force-pushed
the
feat/side-dag/key-cli
branch
from
cc79770 to
92508f9
Compare
msbrogli
previously approved these changes
Jun 4, 2024
jansegre
previously approved these changes
Jun 7, 2024
glevco
force-pushed
the
feat/side-dag/cli
branch
2 times, most recently
from
90a0606 to
2310be5
Compare
glevco
force-pushed
the
feat/side-dag/key-cli
branch
from
7ba3d0f to
d943d41
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
feat/side-dag/key-cli
branch
from
d943d41 to
a417a5d
Compare
jansegre
approved these changes
Jun 10, 2024
msbrogli
approved these changes
Jun 10, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1039
Motivation
Implement a new CLI command to generate private/public keys to be used in Proof-of-Authority signing.
Acceptance Criteria
gen_poa_keysCLI command.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged