feat(cli): Add --log-vertex-bytes for debugging#1033
Merged
Conversation
31d8f3f to
8828816
Compare
glevco
previously approved these changes
May 9, 2024
8828816 to
a9640b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
- Coverage 84.89% 84.89% -0.01%
==========================================
Files 297 297
Lines 22910 22913 +3
Branches 3464 3465 +1
==========================================
+ Hits 19449 19451 +2
+ Misses 2775 2773 -2
- Partials 686 689 +3 ☔ View full report in Codecov by Sentry. |
1 task
jansegre
previously approved these changes
May 20, 2024
Member
jansegre
left a comment
There was a problem hiding this comment.
Looks good to me, but I think it's fine for it to be a regular argument instead (no -x).
a9640b8 to
3a0c176
Compare
3a0c176 to
9b1c03e
Compare
jansegre
approved these changes
May 28, 2024
glevco
approved these changes
May 28, 2024
This was referenced May 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We faced some difficulties replicating issue reports from developers. So this PR introduces a parameter to make replication easier just by sharing the full node log with us.
Acceptance Criteria
--log-vertex-bytesparameter in the run_node cli.VertexHandler._log_vertex_bytes: boolwhich defaults to false.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged