Conversation
8b85724 to
d318e5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
+ Coverage 84.89% 84.90% +0.01%
==========================================
Files 297 297
Lines 22913 22910 -3
Branches 3465 3464 -1
==========================================
Hits 19451 19451
- Misses 2773 2774 +1
+ Partials 689 685 -4 ☔ View full report in Codecov by Sentry. |
glevco
previously approved these changes
May 15, 2024
jansegre
reviewed
May 23, 2024
jansegre
previously approved these changes
May 23, 2024
d318e5a to
d2e5c88
Compare
4fe2936 to
87caccd
Compare
jansegre
approved these changes
May 28, 2024
glevco
approved these changes
May 28, 2024
…ions as they are found in a log dump
87caccd to
d862f01
Compare
This was referenced May 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This new command makes it easier to replay logs generated using
--log-vertex-bytes(#1033).I initially thought that we could replay even the timestamp by using a custom reactor and getting a tighter control of the time. But it was not needed yet for my debugging so I decided to postpone it to another PR.
Acceptance Criteria
load_from_logsthat loads blocks and transactions as they are found in a log dump generated using--log-vertex-bytes. All vertices are processed in the same order as they appear in the log file.run_nodeare available so one can configure the environment where the replay will take place. A new required argument--log-dumpwas added to get the path of the log file that will be replayed.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged