Skip to content

feat(cli): Add --log-vertex-bytes for debugging #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msbrogli merged 1 commit into from
May 28, 2024
Merged

feat(cli): Add --log-vertex-bytes for debugging #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hathor/builder/cli_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ def create_manager(self, reactor: Reactor) -> HathorManager:
feature_service=self.feature_service,
pubsub=pubsub,
wallet=self.wallet,
log_vertex_bytes=self._args.log_vertex_bytes,
)

self.manager = HathorManager(
Expand Down
2 changes: 2 additions & 0 deletions hathor/cli/run_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ def create_parser(cls) -> ArgumentParser:
# XXX: this is temporary, should be added as a sysctl instead before merging
parser.add_argument('--x-ipython-kernel', action='store_true',
help='Launch embedded IPython kernel for remote debugging')
parser.add_argument('--log-vertex-bytes', action='store_true',
help='Log tx bytes for debugging')
return parser

def prepare(self, *, register_resources: bool = True) -> None:
Expand Down
1 change: 1 addition & 0 deletions hathor/cli/run_node_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,4 @@ class RunNodeArgs(BaseModel, extra=Extra.allow):
x_asyncio_reactor: bool
x_ipython_kernel: bool
nano_testnet: bool
log_vertex_bytes: bool
5 changes: 5 additions & 0 deletions hathor/vertex_handler/vertex_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class VertexHandler:
'_feature_service',
'_pubsub',
'_wallet',
'_log_vertex_bytes',
)

def __init__(
Expand All @@ -59,6 +60,7 @@ def __init__(
feature_service: FeatureService,
pubsub: PubSubManager,
wallet: BaseWallet | None,
log_vertex_bytes: bool = False,
) -> None:
self._log = logger.new()
self._reactor = reactor
Expand All @@ -70,6 +72,7 @@ def __init__(
self._feature_service = feature_service
self._pubsub = pubsub
self._wallet = wallet
self._log_vertex_bytes = log_vertex_bytes

def on_new_vertex(
self,
Expand Down Expand Up @@ -223,6 +226,8 @@ def _log_new_object(self, tx: BaseTransaction, message_fmt: str, *, quiet: bool)
'time_from_now': tx.get_time_from_now(now),
'validation': metadata.validation.name,
}
if self._log_vertex_bytes:
kwargs['bytes'] = bytes(tx).hex()
if tx.is_block:
message = message_fmt.format('block')
if isinstance(tx, Block):
Expand Down