Add certificate manager trust config resource

[DanielRieske]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_certificate_manager_trust_config`

Closes:

• Add resource for Certificate Manager Trust Config hashicorp/terraform-provider-google#15473
• Add certificate manager trust-configs for mTLS hashicorp/terraform-provider-google#14984

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[shakeebshams]

LGTM

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1038 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1038 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 172 insertions(+))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_trust_config (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_certificate_manager_trust_config" "primary" {
  description = # value needed
  labels      = # value needed
  location    = # value needed
  name        = # value needed
  trust_stores {
    intermediate_cas {
      pem_certificate = # value needed
    }
    trust_anchors {
      pem_certificate = # value needed
    }
  }
}

[DanielRieske]

I removed the whitespaces and whiteline to pass the linter but I am a little stumped on why it believes there are no acceptance tests.

[modular-magician]

Tests analytics

Total tests: 2950
Passed tests 2643
Skipped tests: 302
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[DanielRieske]

@trodge could you share the test failure for TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample I can't reproduce a failure in my own project.

[trodge]

This is the error:

2023-08-14T19:20:04.324Z [ERROR] sdk.helper_resource: Unexpected error: test_step_number=1 test_terraform_path=/bin/terraform test_working_directory=/tmp/plugintest1551355497
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: Invalid function argument
  | 
  |   on terraform_plugin_test.tf line 9, in resource "google_certificate_manager_trust_config" "default":
  |    9:       pem_certificate = file("test-fixtures/certificatemanager/cert.pem")
  | 
  | Invalid value for "path" parameter: no file exists at
  | "test-fixtures/certificatemanager/cert.pem"; this function works only with
  | files that are distributed as part of the configuration source code, so if
  | this file will be created by a resource in this configuration you must
  | instead obtain this result from an attribute of that resource.
  | 
  | Error: Invalid function argument
  | 
  |   on terraform_plugin_test.tf line 12, in resource "google_certificate_manager_trust_config" "default":
  |   12:       pem_certificate = file("test-fixtures/certificatemanager/cert.pem") 
  | 
  | Invalid value for "path" parameter: no file exists at
  | "test-fixtures/certificatemanager/cert.pem"; this function works only with
  | files that are distributed as part of the configuration source code, so if
  | this file will be created by a resource in this configuration you must
  | instead obtain this result from an attribute of that resource.
   test_name=TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample

[trodge]

I removed the whitespaces and whiteline to pass the linter but I am a little stumped on why it believes there are no acceptance tests.

The missing test detector currently isn't seeing any tests because they've been moved to service packages.

[DanielRieske]

I removed the whitespaces and whiteline to pass the linter but I am a little stumped on why it believes there are no acceptance tests.

The missing test detector currently isn't seeing any tests because they've been moved to service packages.

Ah that explains it, I have multiple PR's claiming fields to be missing in acceptance tests and was already curious what was going on.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1038 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1038 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 172 insertions(+))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_trust_config (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_certificate_manager_trust_config" "primary" {
  description = # value needed
  labels      = # value needed
  location    = # value needed
  name        = # value needed
  trust_stores {
    intermediate_cas {
      pem_certificate = # value needed
    }
    trust_anchors {
      pem_certificate = # value needed
    }
  }
}

[DanielRieske]

I will take a look tomorrow why file("test-fixtures/certificatemanager/cert.pem") can't be found.
At the moment I can't put my finger on it as it seems these fixtures do exist in the project and they are used for several other tests.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1051 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 172 insertions(+))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_trust_config (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_certificate_manager_trust_config" "primary" {
  description = # value needed
  labels      = # value needed
  location    = # value needed
  name        = # value needed
  trust_stores {
    intermediate_cas {
      pem_certificate = # value needed
    }
    trust_anchors {
      pem_certificate = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 172 insertions(+))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2950
Passed tests 2647
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[DanielRieske]

I am going to close this PR and create a new one, I can't seem to fix the branch after rebasing it with main and the changes were relatively small so I will opt on making a new one.

Sorry for the unwanted noise everyone.