Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case sensitivity diff suppression for enums. #8626

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

hankfreund
Copy link
Member

@hankfreund hankfreund commented Aug 11, 2023

Add case sensitivity diff suppression for enums in containeraws resources. The provider accepts upper or lower case enum values, but the server returns them upper case. This causes state mismatch with TF, which leads to clusters being destroyed and re-created.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

containeraws: added diff suppression for case changes of enum values in `google_container_aws_cluster` and `google_container_aws_node_pool`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1113 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1769 insertions(+), 44 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2943
Passed tests 2637
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAwsCluster_BetaBasicEnumHandWritten|TestAccContainerAwsCluster_BasicEnumHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicEnumHandWritten[Debug log]
TestAccContainerAwsNodePool_BasicEnumHandWritten[Debug log]
TestAccContainerAwsCluster_BetaBasicEnumHandWritten[Debug log]
TestAccContainerAwsCluster_BasicEnumHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not familiar with this change, could you re-roll?

@hao-nan-li hao-nan-li requested review from a team and hao-nan-li and removed request for a team and hao-nan-li August 14, 2023 16:06
@c2thorn c2thorn requested review from c2thorn and hao-nan-li and removed request for a team August 14, 2023 17:52
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource changes look like they generated correctly, and tests have passed. LGTM

@c2thorn c2thorn merged commit a758062 into GoogleCloudPlatform:main Aug 14, 2023
8 checks passed
SamGerber pushed a commit to SamGerber/magic-modules that referenced this pull request Aug 14, 2023
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants