-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated 5.0.0 upgrade guide about the change in enableEndpointIndependentMapping's default value #8634
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please replace enableEndpointIndependentMapping
with enable_endpoint_independent_mapping
? Otherwise this looks good to me!
…dentMapping's default value
Done. Thanks for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
…dentMapping's default value (GoogleCloudPlatform#8634)
…dentMapping's default value (GoogleCloudPlatform#8634)
…dentMapping's default value (GoogleCloudPlatform#8634)
…dentMapping's default value (GoogleCloudPlatform#8634)
…dentMapping's default value (GoogleCloudPlatform#8634)
…
In 5.0.0 feature branch, enableEndpointIndependentMapping's default value got changed from true to API's default value which is false. This change is to update the 5.0.0 upgrade guide.
hashicorp/terraform-provider-google#15477
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)