Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 5.0.0 upgrade guide about the change in enableEndpointIndependentMapping's default value #8634

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

shijeesh-ns
Copy link
Contributor

In 5.0.0 feature branch, enableEndpointIndependentMapping's default value got changed from true to API's default value which is false. This change is to update the 5.0.0 upgrade guide.

hashicorp/terraform-provider-google#15477

If this PR is for Terraform, I acknowledge that I have:

  • [ X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ X] Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)



@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 12, 2023
Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace enableEndpointIndependentMapping with enable_endpoint_independent_mapping? Otherwise this looks good to me!

@shijeesh-ns
Copy link
Contributor Author

Could you please replace enableEndpointIndependentMapping with enable_endpoint_independent_mapping? Otherwise this looks good to me!

Done. Thanks for reviewing.

Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 14, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+))

@SarahFrench SarahFrench merged commit c862576 into GoogleCloudPlatform:main Aug 15, 2023
8 checks passed
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants