Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

feat(i18n): allow easy navigation in /i18n/ directory, fixes #6669 #7283

Closed
wants to merge 4 commits into from

Conversation

MichaelSolati
Copy link
Contributor

@MichaelSolati MichaelSolati commented Jan 31, 2022

Fixes #6669

Changes proposed in this pull request:

  • If user navigates to /SOME_LOCALE/:path redirect them to /i18n/SOME_LOCALE/:path;
  • If user goes to a /i18n/SOME_LOCALE/:path that doesn't exist, redirect them to /:path
  • If user navigates to /i18n/:path redirect them to/:path
  • If user is on /i18n/SOME_LOCALE/:path and clicks link, navigate them to /i18n/SOME_LOCALE/:href_of_link

When you're ready to submit your PR, don't forget to add the $-presubmit label.

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: eeb9534

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/61f8f77985def900083c4414

😎 Browse the preview: https://deploy-preview-7283--web-dev-staging.netlify.app

@pullapprove pullapprove bot requested a review from devnook January 31, 2022 22:01
@MichaelSolati MichaelSolati changed the title feat(i18n): allow easy navigation in /i18n/ directory feat(i18n): allow easy navigation in /i18n/ directory, fixes #6669 Jan 31, 2022
@stale
Copy link

stale bot commented Jun 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Jun 11, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

Closing this issue because it has been marked as stale for more than 7 days.

@stale stale bot closed this Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If an article with a locale does not exist, it should redirect to the default language version
1 participant