Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

If an article with a locale does not exist, it should redirect to the default language version #6669

Closed
tomayac opened this issue Nov 3, 2021 · 3 comments
Assignees
Labels
accepted **Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open. eng For items that require engineering work. P2 A normal priority task. This is the default for most issues. stale

Comments

@tomayac
Copy link
Member

tomayac commented Nov 3, 2021

Assume there were a locale foo. A request to the non-existent URL /foo/bar/ will currently result in a 404 error. As an alternative, there could be a redirect (attempt) to /bar/, that is, the default language version of the article. This may or may not exist, but it's an educated guess.

This caught us in practice with a link issue where they point at /pl/clipchamp (404 error), but where /clipchamp exists.

@tomayac tomayac added P2 A normal priority task. This is the default for most issues. eng - bug Something broke! labels Nov 3, 2021
@MichaelSolati MichaelSolati self-assigned this Nov 4, 2021
@devnook devnook added the L3 label Nov 11, 2021
@devnook devnook added eng For items that require engineering work. and removed eng - bug Something broke! eng - L3 labels Feb 7, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Jun 12, 2022
@tomayac tomayac removed the stale label Jun 13, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Sep 21, 2022
@tomayac tomayac added the accepted **Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open. label Sep 21, 2022
@tomayac
Copy link
Member Author

tomayac commented Sep 21, 2022

The incorrect link on the site still exists, and we still don't have an answer. One way to deal with this would be to add a one-off redirect (https://web.dev/pl/clipchamp/https://web.dev/clipchamp/). It might bite us once we actually add a Polish translation and we forget that the redirect exists.

@devnook devnook closed this as completed Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted **Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open. eng For items that require engineering work. P2 A normal priority task. This is the default for most issues. stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants