This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Redirect i18n URLs that would be valid without the locale prefix #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize that we have some tests for server functionality, so I'll add a new test to this PR to cover the |
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I've added a few tests for the |
devnook
approved these changes
Apr 1, 2022
|
Let's merge on Monday, as I would prefer there not to be any surprises with our server code over the weekend 😄 |
|
I noticed lhci is unhappy, because robots-txt changed location. Let's resolve it before merging. |
|
Are we sure that LHCI error is legitimate? I don't see a https://developer.chrome.com/robots.txt on the production website, either. Let's chat about it on Monday. |
…me.com into redirect-i18n-404s
devnook
reviewed
Apr 4, 2022
devnook
suggested changes
Apr 4, 2022
Merged
devnook
approved these changes
Apr 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @devnook
CC: @agektmr
Fixes #2398
This shares a similar goal to GoogleChrome/web.dev#7283, but that PR was never merged, and the d.c.c. serving infrastructure differs from web.dev, so I wanted to write something fresh and focused.
The behavior implemented in this PR is:
404today, check whether replacing the first item in the path with the default locale (en) would lead to a valid HTML document.404, return a302redirecting to the non-localized version of that URL.404as before.One approach that I considered, but ultimately decided against, was returning the HTML content from the default locale as a
200response directly from the localized URL, instead of redirecting. That seemed riskier from the point of view of indexing, so I went with a redirect instead.