Skip to content

Bump SharpCompress from 0.48.1 to 0.50.4 - #81

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.4
Open

Bump SharpCompress from 0.48.1 to 0.50.4#81
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 10, 2026

Copy link
Copy Markdown
Contributor

Updated SharpCompress from 0.48.1 to 0.50.4.

Release notes

Sourced from SharpCompress's releases.

0.50.3

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.50.2...0.50.3

0.50.2

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.50.1...0.50.2

0.50.1

What's Changed

Thanks for reporting!

Full Changelog: adamhathcock/sharpcompress@0.50.0...0.50.1

0.50.0

Breaking changes:

  • Tar Archive does not try to decompress streams anymore. TarReader will still do this.
  • Detection API changed.
  • CRC should be more complete and enabled by default

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.49.1...0.50.0

0.49.1

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0...0.49.1

0.49.0

This should contain a lot of write async fixes and some breaking API changes that fix previous broke net48 usage

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0

0.49.0-beta.140

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0-beta.136...0.49.0-beta.140

0.49.0-beta.136

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0-beta1

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump SharpCompress from 0.48.1 to 0.50.4
52181cd 
---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-version: 0.50.4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Aug 10, 2026
@dependabot
dependabot Bot requested a review from GoodOlClint as a code owner August 10, 2026 12:36
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Aug 10, 2026
@dependabot dependabot Bot mentioned this pull request Aug 10, 2026
Closed
@claude

claude Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Claude finished @dependabot[bot]'s task in 1m 8s —— View job

Review: Bump SharpCompress 0.48.1 → 0.50.4

  • Gather context (diff, DECISIONS.md, findings.json)
  • Check how SharpCompress is used in the codebase
  • Check for breaking changes between 0.48.1 and 0.50.4 that affect usage
  • Check tests reference SharpCompress behavior
  • Post review summary

Summary

This is a routine dependabot dependency bump — a single-line version change in src/PSProxmoxVE.Core/PSProxmoxVE.Core.csproj (0.48.1 → 0.50.4), no other files touched.

Usage in this repo: SharpCompress is used in exactly one place, src/PSProxmoxVE.Core/Models/Vms/OvfMetadata.cs:89, via the streaming SharpCompress.Readers.ReaderFactory.OpenReader(...) API to extract the .ovf XML from an OVA (TAR) file.

Breaking-change check (0.48.1 → 0.50.4): The 0.50.0 release notes call out breaking changes, but they're scoped to the Archive/detection APIs:

  • "Tar Archive does not try to decompress streams anymore. TarReader will still do this."
  • "Detection API changed."
  • "CRC should be more complete and enabled by default."

Since this code uses the Readers (streaming) API, not TarArchive, the tar-decompression breaking change doesn't apply here. The CRC-by-default change could theoretically cause a previously-tolerated stream to now throw on a CRC mismatch, but that's a correctness improvement, not a regression risk introduced by this bump, and there's no indication OVA parsing relied on lenient CRC handling.

DECISIONS.md / findings.json: No architectural decisions (D001–D013) or open findings reference SharpCompress or OvfMetadata. Nothing regressed by this change.

Tests: There's an integration test that exercises this path (tests/PSProxmoxVE.Tests/Integration/12_OVA.Tests.ps1:34, calling OvfMetadata::FromOva), but it's gated as an integration test (requires nested PVE via ./tests/dev.ps1 integration) — it isn't part of the standard dotnet test / Pester unit run. I was not able to execute dotnet build or the test suite in this sandbox (Bash tool calls for dotnet build/dotnet test were blocked pending approval), so I could not confirm compilation/test-pass locally — rely on the CI build check for that confirmation.

Verdict: No DECISIONS.md violations, no code-quality/security concerns — this is a low-risk, narrow-surface-area dependency update. Safe to merge once CI (build + tests) passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GoodOlClint GoodOlClint Awaiting requested review from GoodOlClint GoodOlClint is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants