Skip to content

Bump SharpCompress from 0.48.1 to 0.50.3 - #80

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.3
Closed

Bump SharpCompress from 0.48.1 to 0.50.3#80
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 3, 2026

Copy link
Copy Markdown
Contributor

Updated SharpCompress from 0.48.1 to 0.50.3.

Release notes

Sourced from SharpCompress's releases.

0.50.3

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.50.2...0.50.3

0.50.2

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.50.1...0.50.2

0.50.1

What's Changed

Thanks for reporting!

Full Changelog: adamhathcock/sharpcompress@0.50.0...0.50.1

0.50.0

Breaking changes:

  • Tar Archive does not try to decompress streams anymore. TarReader will still do this.
  • Detection API changed.
  • CRC should be more complete and enabled by default

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.49.1...0.50.0

0.49.1

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0...0.49.1

0.49.0

This should contain a lot of write async fixes and some breaking API changes that fix previous broke net48 usage

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0

0.49.0-beta.140

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0-beta.136...0.49.0-beta.140

0.49.0-beta.136

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0-beta1

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump SharpCompress from 0.48.1 to 0.50.3
e9d9088 
---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-version: 0.50.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Aug 3, 2026
@dependabot
dependabot Bot requested a review from GoodOlClint as a code owner August 3, 2026 12:36
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Aug 3, 2026
@dependabot dependabot Bot mentioned this pull request Aug 3, 2026
Closed
@claude

claude Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Claude finished @dependabot[bot]'s task in 1m 13s —— View job

Review: Bump SharpCompress 0.48.1 → 0.50.3

  • Gather context (diff, DECISIONS.md, findings.json)
  • Check DECISIONS.md compliance
  • Check for SharpCompress usage in codebase (API breaking changes)
  • Check security/build implications
  • Post final review

Summary

This is a minimal, low-risk dependency bump — a single-line version change in src/PSProxmoxVE.Core/PSProxmoxVE.Core.csproj (0.48.1 → 0.50.3). No source changes accompany it.

DECISIONS.md compliance: No violations. This PR doesn't touch cmdlets, models, or services, so D001–D013 don't apply.

SharpCompress usage check: The only consumer in this repo is OvfMetadata.ExtractOvfFromTar in src/PSProxmoxVE.Core/Models/Vms/OvfMetadata.cs:86-104, which uses the streaming SharpCompress.Readers.ReaderFactory.OpenReader API to read .ovf XML out of an OVA (TAR) archive.

I checked this against the breaking changes called out for 0.50.0 in the release notes:

  • "Tar Archive does not try to decompress streams anymore. TarReader will still do this." — this code uses ReaderFactory/TarReader, not the Archive API, so it's unaffected.
  • "Detection API changed" — no detection API (ArchiveFactory.IsArchive, etc.) is used here.

No other breaking changes in 0.49.x–0.50.3 (async writer changes, LeaveStreamOpen default flip, ArchiveInformation additions) touch reader-based TAR extraction. Overall this update looks safe for this codebase's usage.

Tests: There's no xUnit test directly covering OvfMetadata.FromOva/SharpCompress behavior — only a Pester integration test (tests/PSProxmoxVE.Tests/Integration/12_OVA.Tests.ps1) that requires a provisioned nested PVE environment to exercise the real OVA extraction path. That's a pre-existing test gap, not something introduced by this PR, so no new test is required here.

Build verification: I was unable to run dotnet build/dotnet test locally in this sandbox (command required approval that wasn't available in this context) to independently confirm compile-time compatibility. The repo's own CI (Build / Unit Tests workflows) was in progress at review time and is the authoritative signal — please confirm those pass before merging. If you'd like me to verify builds directly in future reviews, dotnet build/dotnet test would need to be added to --allowedTools.

Security: No hardcoded credentials or secrets involved; this is a transitive-dependency-free direct package bump with no code changes.

No blocking issues found. Recommend merging once CI (Build/Unit Tests) is green.

@dependabot @github

dependabot Bot commented on behalf of github Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #81.

@dependabot dependabot Bot closed this Aug 10, 2026
@dependabot
dependabot Bot deleted the dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.3 branch August 10, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GoodOlClint GoodOlClint Awaiting requested review from GoodOlClint GoodOlClint is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants