Skip to content

Conversation

@viktorrenkema
Copy link
Contributor

  • Sets the new height property on the page cover, set in the app or through md
  • Changed the way we set the y position of a page cover to align the app
  • Added a shimmer state to better fallback UI while cover is retrieved and avoid the objectPosition shifting from default 50% to whatever value was set.

Demo

CleanShot.2025-10-27.at.10.05.13.mp4

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

⚠️ No Changeset found

Latest commit: 111b2ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 32 changed Oct 27, 2025, 12:43 PM
v2-cloudflare (Inspect) 👍 Changes approved 18 changed Oct 27, 2025, 12:46 PM
v2-vercel (Inspect) 👍 Changes approved 17 changed Oct 27, 2025, 12:47 PM

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we do it in CSS only to avoid a client component here?

@viktorrenkema
Copy link
Contributor Author

Can't we do it in CSS only to avoid a client component here?

I don't think that's reasonably possible as ultimately we are dependent on the page cover's container dimensions which adapt to the viewport in which its rendered. Even if we could make it fully css-based, it'd require rethinking the entire setup and i dont think that's worth spending the time rn.

@viktorrenkema viktorrenkema merged commit f682df1 into main Oct 27, 2025
16 checks passed
@viktorrenkema viktorrenkema deleted the codex/add-support-for-coverheight-property-2 branch October 27, 2025 14:55
viktorrenkema added a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants