-
Notifications
You must be signed in to change notification settings - Fork 4k
Support cover image heights and positioning changes #3758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cover image heights and positioning changes #3758
Conversation
|
e842e50 to
b1b9ace
Compare
b1b9ace to
d7486df
Compare
d7486df to
e3c8adb
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we do it in CSS only to avoid a client component here?
0c3dbd2 to
111b2ec
Compare
I don't think that's reasonably possible as ultimately we are dependent on the page cover's container dimensions which adapt to the viewport in which its rendered. Even if we could make it fully css-based, it'd require rethinking the entire setup and i dont think that's worth spending the time rn. |
This reverts commit f682df1.
heightproperty on the page cover, set in the app or through mdyposition of a page cover to align the appDemo
CleanShot.2025-10-27.at.10.05.13.mp4