Skip to content

docs(gui): add Hermes3D OS visual reference pack - #128

Closed
Ghenghis wants to merge 1 commit into
codex/claude-hermes-runtime-finish-contract-2026-05-08from
codex/gui-reference-pack-2026-05-08
Closed

Ghenghis wants to merge 1 commit into
codex/claude-hermes-runtime-finish-contract-2026-05-08from
codex/gui-reference-pack-2026-05-08

Conversation

@Ghenghis

@Ghenghis Ghenghis commented May 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds Images-GUI/, a complete Hermes3D OS visual reference pack for the new dark, multicolor, pixel-target GUI direction.
  • Includes 31 PNG references covering the user-provided current direction, Simple / Advanced / Custom dashboards, action-window workspaces, all primary tabs, settings, voice, Source OS / 60-app coverage, plugins, skills, MCP, responsive states, and theme variants.
  • Adds README.md and GUI_REFERENCE_MANIFEST.json so Claude/Codex can treat the pack as the visual oracle for future implementation PRs.

Coverage

  • Primary tabs: 16 / 16 covered
  • Settings subtabs: 6 / 6 covered
  • Voice subtabs: 3 / 3 covered
  • Source OS categories: 11 / 11 covered
  • 60-app workbench: included
  • Dashboard modes: Simple, Advanced, Custom
  • Theme direction: default darker blue plus Cyberpunk, Matrix, Tron, Industrial, Blueprint, Light Lab

Notes

  • This PR does not implement runtime UI code. It creates the reference collection Claude/Codex should use for pixel-by-pixel UI implementation.
  • These images are design/reference truth, not runtime proof. Future implementation PRs still require Playwright screenshots, console checks, no-fake scan, and tests.
  • Unrelated Claude audit files were left untracked and were not staged.

Verification

  • git diff --cached --check
  • python -m json.tool Images-GUI/GUI_REFERENCE_MANIFEST.json
  • PNG count check: 31 files, total 53.05 MB, largest 2.02 MB
  • Pre-push fast subset: static gates PASS, 39 tests PASS

@coderabbitai

coderabbitai Bot commented May 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 25a37858-73a8-41e2-a4c7-d4f9ff319005

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/gui-reference-pack-2026-05-08

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a GUI reference pack for the Hermes3D OS, consisting of a manifest JSON and a detailed README that define the visual direction, page coverage, and implementation standards. The review feedback highlights several inconsistencies that need to be addressed to ensure the pack serves as an accurate source of truth: specifically, discrepancies in panel radius values compared to existing design tokens, the classification of the 'Roadmap' tab relative to the current routing implementation, and naming inconsistencies for the default theme between the manifest and documentation.

Comment thread Images-GUI/README.md

- Even darker background than the current app.
- Multi-color accents, not a one-note blue dashboard.
- Sharp operational panels, about 6px radius.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The visual direction specifies a 6px radius for panels, which creates a discrepancy with the existing implementation. tailwind.config.ts (line 36) defines a card radius of 8px, while tokens.ts (line 7) uses 20px. Aligning these values is necessary for this pack to serve as an accurate visual oracle for future implementation.

Comment thread Images-GUI/README.md
- Approvals
- Plugins
- Settings
- Roadmap

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The classification of Roadmap as a "Primary Hermes3D tab" in this documentation conflicts with the codebase implementation in 03_implementation/ui/src/app/routes.tsx (line 42), where it is explicitly excluded from the PRIMARY_TABS array. This inconsistency should be resolved to maintain the "source-of-truth" status of this reference pack.

}
},
"themes": [
"default_hermes_dark",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The identifier "default_hermes_dark" used here is inconsistent with the README.md (lines 18, 48), which refers to the theme as default. Using a consistent name across the manifest and documentation is recommended.

Suggested change
"default_hermes_dark",
"default",

@Ghenghis
Ghenghis deleted the branch codex/claude-hermes-runtime-finish-contract-2026-05-08 May 9, 2026 07:09
@Ghenghis Ghenghis closed this May 9, 2026
Ghenghis added a commit that referenced this pull request May 9, 2026
…ontinuation) (#151)

User-mandated FIRST step in the E2E Master Continuation. Reconciles every
existing audit / registry / matrix / handoff / merged PR into a single
source of truth.

Inputs reconciled
- E2E_BLOCKER_REGISTRY_2026-05-09.md (PR #142)
- REMAINING_SKIPPED_BLOCKERS_WAVE_2026-05-09.md (PR #146)
- 60_APP_UPDATE_READINESS_AUDIT_2026-05-09.md (PR #135)
- 60-apps-batch2/* (Bonus 12, Bonus 13, agent7-11, bonus14)
- Images-GUI/ reference pack (PR #128/#134)
- All 15 merged PRs #136-#150 today
- Wave 1 (20-agent Blocker Elimination Swarm) receipts
- Wave 2 (10-agent Remaining/Skipped Wave) receipts

Sections
1. PR ledger: 15 PRs today, all squash, no fake passes
2. Reconciled blocker matrix: closed (13), partial (2), upstream-blocked (1),
   open (7), deferred-by-lock (1)
3. E2E Definition of Done: 14 items checklist with status
4. Hard gates: v0.13 retry CLOSED, GUI Playwright OPEN (dashboard-advanced),
   RC v2 resume OPEN, OpenCode/Hands OPEN
5. Open by category: P0 (none), P1 (4), P2 (4)
6. Hard external blockers (cannot fix in code): BLK-009 server, BLK-011
   upstream, license / repo-identity / Hunyuan reviews needed from user
7. Provenance: 30+ research receipts banked, MCP evidence chain unbroken,
   1 honest 1-loop escalation, 0 fake passes, 0 secret values exposed

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Ghenghis added a commit that referenced this pull request May 10, 2026
W5-8's 18-doc audit (`V013_PROMOTION_DOC_AUDIT_2026-05-09.md`) found 24
issues across the v0.13 promotion docs. This consolidated PR closes 20
of them; the remaining 4 are out-of-scope (P3 cosmetic / on docs that
do not yet exist on this integration branch).

P1 closed (9):
- BLK-011 supersession block + DoD #3 update in `E2E_BLOCKER_REGISTRY`
- §6 "KEEP DEFERRED" supersession in `REMAINING_SKIPPED_BLOCKERS_WAVE`
- POST-MERGE banner in `PR125_CONTROL_SWEEP_HANDOFF` (PR #125 merged
  2026-05-09T07:09Z) + provider rescue supersession (MiniMax/DeepSeek
  now PASS HTTP 200 per `PROVIDER_RESCUE_BLOCKER_PROOF`)
- Broken local link in `60_APP_UPDATE_READINESS_AUDIT` repointed at
  the orchestrator-repo URL; new stub doc created locally
- §3.6 row + L317 line in `60_APP_UPDATE_READINESS_AUDIT` superseded
  by PR #160; `is_container()/is_wsl()` issue #22420 stricken
  pending verification (`gh api` returns 404)
- BLK-021 cold-start race added to `E2E_BLOCKER_REGISTRY` (was only
  in `HERMES_AGENT_V013_GUI_E2E` which is on a different branch)

P2 closed (8):
- 12 broken file paths in `E2E_FILE_BY_FILE_COVERAGE` corrected to
  match on-disk layout (`services/`, `db/`, actual UI tab names,
  actual integration-test names)
- "PR #128/#134" → "PR #134; supersedes closed PR #128" in
  `E2E_COMPLETION_MASTER_REGISTRY`
- EXECUTED banner on `HERMES_AGENT_PRODUCTION_V013_ACTION_PLAN`
- "FULLY LIFTED" amendment on `HERMES_AGENT_ONLY_SWARM_STATUS`
- Empty `V013_PROMOTION_MERGE_PLAN` populated with executed-PR ledger
- Speculative "(if exists)" rows removed from
  `E2E_FILE_BY_FILE_COVERAGE` Part 3

P3 closed (3):
- Provenance footnote on the "447 files" claim
- Action 2 + Action 4 file refs synced with corrected paths
- Lane-proof footnote pointing at orchestrator repo

Out-of-scope on this branch (4): per-doc P3 cosmetic items that
require renaming `V013_LIVE_PROBE_RESULTS_TEMPLATE` (file is on
W5-7 branch) and Phase B "EXECUTED" banner on
`V013_PROMOTION_CROSS_PR_CONFLICT_MAP` (file is on W5-1 branch).
Those will land when their host branches merge.

Source-of-truth verification:
- `services/agent_checkout.py:L31` — `DEFAULT_AGENT_CHECKOUT =
  Path("G:/Github/hermes-agent-v013-canary")` (matches docs)
- `services/agent_checkout.py:L27` — `V012_FALLBACK_CHECKOUT =
  Path("G:/Github/hermes-agent-fresh")` (matches docs)
- All PR refs verified via `gh pr view <N> --json state,mergedAt`
- 35/45 backtick-quoted repo paths in touched docs resolve via
  `pathlib.Path.exists()`; the 10 unresolved are explicitly labeled
  "(spec drafted; not yet committed)" / "(new file, ~330 LoC)" /
  "(proposed)" / glob notation

Constraints honored:
- No source-code edits (this is a doc-only PR)
- No secret values introduced (verified by 4-class regex scan)
- All 10 touched docs locked under `claude-w5-8b-doc-fix`
- 2 sources cited: Microsoft Writing Style Guide + Diátaxis (same
  as W5-8's audit doc)

Hermes evidence chain: PASS
Task ID: W5-8b-DOC-FIX-2026-05-09
hermes_run_gate: doc paths resolve; constants match source

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Ghenghis added a commit that referenced this pull request May 10, 2026
W8-14 left 11 live targets reporting a uniform ~0.28-0.31 diff ratio
because the harness viewport (1920x1080) did not match the Images-GUI/
reference PNG dimensions (1536x1024 for 9 of 11). toHaveScreenshot is
not resolution-tolerant, so the diff was geometric, not content.

Surgical fix: drop the harness viewport to 1536x1024 to match the
reference pack (single source of truth, PR #128 user-approved).

  03_implementation/ui/playwright.visual.config.ts (use.viewport +
    projects[0].use.viewport)
  03_implementation/ui/tests/visual/visual-targets.json (viewport +
    new reference_viewport field for clarity)

Re-run delta vs PR #194:
  before: 0 match / 11 diff / 0 error / 20 skipped
  after:  9 match / 1 diff / 1 error / 20 skipped

Two remaining failures are NOT viewport-related — both are reference
PNGs captured at non-canonical sizes:

  04_source_os_60_app_coverage_matrix : ref 1672x941 (diff)
  04_source_os_remaining_categories   : ref 1586x992 (error)

Both need re-capture in PR #128 v2 (Images-GUI maintainer scope, NOT
W8-15). Documented in
03_implementation/docs/handoffs/W8-15_VISUAL_VIEWPORT_ALIGN_2026-05-09.md
with diff_pixels, ratio, evidence_path, and next_fix_attempt for each.

Stacks on PR #194 (W8-14 harness fix). Builds on PR #188 (W8-12 Vite
Fast-Refresh) for the SPA mount.

No --update-snapshots, no reference PNGs touched, no paid services.
visual-proof.spec.ts unchanged (no hardcoded viewport literals).

Sources cited:
  - https://playwright.dev/docs/api/class-testoptions#test-options-viewport
  - Images-GUI/ folder pack from PR #128 (verified PNG IHDR dims)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Ghenghis added a commit that referenced this pull request May 10, 2026
W8-14 left 11 live targets reporting a uniform ~0.28-0.31 diff ratio
because the harness viewport (1920x1080) did not match the Images-GUI/
reference PNG dimensions (1536x1024 for 9 of 11). toHaveScreenshot is
not resolution-tolerant, so the diff was geometric, not content.

Surgical fix: drop the harness viewport to 1536x1024 to match the
reference pack (single source of truth, PR #128 user-approved).

  03_implementation/ui/playwright.visual.config.ts (use.viewport +
    projects[0].use.viewport)
  03_implementation/ui/tests/visual/visual-targets.json (viewport +
    new reference_viewport field for clarity)

Re-run delta vs PR #194:
  before: 0 match / 11 diff / 0 error / 20 skipped
  after:  9 match / 1 diff / 1 error / 20 skipped

Two remaining failures are NOT viewport-related — both are reference
PNGs captured at non-canonical sizes:

  04_source_os_60_app_coverage_matrix : ref 1672x941 (diff)
  04_source_os_remaining_categories   : ref 1586x992 (error)

Both need re-capture in PR #128 v2 (Images-GUI maintainer scope, NOT
W8-15). Documented in
03_implementation/docs/handoffs/W8-15_VISUAL_VIEWPORT_ALIGN_2026-05-09.md
with diff_pixels, ratio, evidence_path, and next_fix_attempt for each.

Stacks on PR #194 (W8-14 harness fix). Builds on PR #188 (W8-12 Vite
Fast-Refresh) for the SPA mount.

No --update-snapshots, no reference PNGs touched, no paid services.
visual-proof.spec.ts unchanged (no hardcoded viewport literals).

Sources cited:
  - https://playwright.dev/docs/api/class-testoptions#test-options-viewport
  - Images-GUI/ folder pack from PR #128 (verified PNG IHDR dims)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant