feat(ui): visual-proof viewport align to 1536x1024 (Wave 8 W8-15, replaces auto-closed #195) - #196
Merged
Ghenghis merged 1 commit intoMay 10, 2026
Conversation
W8-14 left 11 live targets reporting a uniform ~0.28-0.31 diff ratio because the harness viewport (1920x1080) did not match the Images-GUI/ reference PNG dimensions (1536x1024 for 9 of 11). toHaveScreenshot is not resolution-tolerant, so the diff was geometric, not content. Surgical fix: drop the harness viewport to 1536x1024 to match the reference pack (single source of truth, PR #128 user-approved). 03_implementation/ui/playwright.visual.config.ts (use.viewport + projects[0].use.viewport) 03_implementation/ui/tests/visual/visual-targets.json (viewport + new reference_viewport field for clarity) Re-run delta vs PR #194: before: 0 match / 11 diff / 0 error / 20 skipped after: 9 match / 1 diff / 1 error / 20 skipped Two remaining failures are NOT viewport-related — both are reference PNGs captured at non-canonical sizes: 04_source_os_60_app_coverage_matrix : ref 1672x941 (diff) 04_source_os_remaining_categories : ref 1586x992 (error) Both need re-capture in PR #128 v2 (Images-GUI maintainer scope, NOT W8-15). Documented in 03_implementation/docs/handoffs/W8-15_VISUAL_VIEWPORT_ALIGN_2026-05-09.md with diff_pixels, ratio, evidence_path, and next_fix_attempt for each. Stacks on PR #194 (W8-14 harness fix). Builds on PR #188 (W8-12 Vite Fast-Refresh) for the SPA mount. No --update-snapshots, no reference PNGs touched, no paid services. visual-proof.spec.ts unchanged (no hardcoded viewport literals). Sources cited: - https://playwright.dev/docs/api/class-testoptions#test-options-viewport - Images-GUI/ folder pack from PR #128 (verified PNG IHDR dims) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Ghenghis
merged commit May 10, 2026
f20d40c
into
feat/hermes3d-7-complete-gui-repo-wiring
3 checks passed
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacement for auto-closed #195. Original PR #195 was closed by GitHub when its base branch
claude/w8-14-visual-proof-harness-fixwas deleted upon #194's squash-merge. This PR re-targets the same change ontofeat/hermes3d-7-complete-gui-repo-wiring(post-#194 base).W8-14 left 11 live targets reporting a uniform ~0.28-0.31 diff ratio because the harness viewport (1920x1080) did not match the Images-GUI/ reference PNG dimensions (1536x1024 for 9 of 11).
toHaveScreenshotis not resolution-tolerant, so the diff was geometric, not content. Surgical fix drops harness viewport to 1536x1024 (single source of truth, PR #128 user-approved).Changed files:
03_implementation/ui/playwright.visual.config.ts—use.viewport+projects[0].use.viewport03_implementation/ui/tests/visual/visual-targets.json— viewport +reference_viewportfield03_implementation/docs/handoffs/W8-15_VISUAL_VIEWPORT_ALIGN_2026-05-09.md— handoff doc03_implementation/evidence/visual_proof_2026-05-09/summary.json— re-run evidenceRe-run delta vs PR #194:
Two remaining failures are NOT viewport-related — both are reference PNGs captured at non-canonical sizes (
04_source_os_60_app_coverage_matrixref 1672x941,04_source_os_remaining_categoriesref 1586x992). Both need re-capture in PR #128 v2 (Images-GUI maintainer scope, NOT W8-15).Mechanical-review fields
claude/w8-14-visual-proof-harness-fixdeleted)Test plan
b2f7c548)--update-snapshots, no reference PNGs modifiedvisual-proof.spec.tsunchanged (no hardcoded viewport literals)feat/hermes3d-7-complete-gui-repo-wiringSources:
🤖 Generated with Claude Code