Skip to content

Add PSHB to agencies dropdown#1377

Merged
jc-gsa merged 1 commit intomainfrom
add-more-agencies
Oct 28, 2024
Merged

Add PSHB to agencies dropdown#1377
jc-gsa merged 1 commit intomainfrom
add-more-agencies

Conversation

@monfresh
Copy link
Copy Markdown
Contributor

@monfresh monfresh commented Oct 24, 2024 •
edited
Loading

🛠 Summary of changes

Now that we have the translations for PSHB, we can add them to the agency dropdown.

In the future, it would be nice to be able to publish the English version first, and then follow up with the translations when they're ready.

🎫 Ticket

LG-14744

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • If testing locally, pull down this branch, then run make setup and then make run
  • Visit http://localhost:4000/contact/ in your favorite browser
  • Click on the "Partner Agency" dropdown
  • Verify that the following entry exists: Postal Service Health Benefits (PSHB)
  • Change the language to Spanish (from the Language dropdown at the top of the site), and verify this entry exists: Beneficios de salud del servicio postal (PSHB)
  • Change the language to French, and verify this entry exists: Prestations de santé des services postaux (PSHB)
  • Change the language to Chinese, and verify this entry exists: 美国邮局医疗福利（Postal Service Health Benefits） (PSHB)

@monfresh monfresh requested a review from jc-gsa October 24, 2024 16:38
jc-gsa
jc-gsa reviewed Oct 24, 2024
View reviewed changes
_data/en/settings.yml
'Pay.gov': Pay.gov
'PBGC-MyPBA': 'PBGC - MyPBA'
'Peace Corps': Peace Corps
'Postal Service Health Benefits (PSHB)': Postal Service Health Benefits (PSHB)
Copy link
Copy Markdown
Contributor

@jc-gsa jc-gsa Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could add the translations for PSHB we can merge that easily. We can double check the status of the translations for FRB.

Copy link
Copy Markdown
Contributor Author

@monfresh monfresh Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! And I also removed FRB for now.

@monfresh
Add PSHB to agencies dropdown
07cc836 
Now that we have the translations for PSHB, we can add them to the
agency dropdown.

In the future, it would be nice to be able to publish the English
version first, and then follow up with the translations when they're
ready.

Closes LG-14744
@monfresh monfresh changed the title Add FRB and PSHB to agencies dropdown Add PSHB to agencies dropdown Oct 24, 2024
@monfresh monfresh requested a review from jc-gsa October 24, 2024 17:46
jc-gsa
jc-gsa approved these changes Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jc-gsa jc-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for PSHB. LGTM.

@jc-gsa jc-gsa merged commit c9465a2 into main Oct 28, 2024
@jc-gsa jc-gsa deleted the add-more-agencies branch October 28, 2024 18:42
jc-gsa pushed a commit that referenced this pull request Dec 19, 2024
@monfresh @jc-gsa
Add PSHB to agencies dropdown (#1377)
0188f3f 
Add PSHB to agencies dropdown
jc-gsa added a commit that referenced this pull request Dec 19, 2024
@jc-gsa @n1zyy
@matthinz @kevinsmaster5 @akhlaqkhan @esther2kim @PonjaHO @allisonrosenberg @AShukla-GSA @gina-yamada @dependabot @KeithNava @monfresh @aduth
LG-13755: Add "program updates" (#1409)
b7c5e74 
* Add program updates collection

* Add program update admin config

* Update Jekyll collection

* Update Netlify config for program updates

* Add program updates to partners header

* Add scaffolding placeholder html

* Add placeholder page

* Temporarily modify config for testing

* Update placeholder variables

* Update index scaffold

* Update entry scaffold

* Update index style

* Remove unnecessary param

* Update index page

* Update subtitle

* Update description

* Correct uploaded image path

* Add preview field

* Use preview field in template

* Remove early figma draft

* Update spacing

* Add preview text var

* Use preview var

* Add preview component

* Add vars from Jekyll

* Change component preview

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "assets/img/450px.png"
* "content/_program_updates/test-title-1.md"

* Delete Program update “test-title-1”

* LG-14223 | Use icon bullets on "Verify your phone number" page (#1329)

* LG-14081: Add privacy translations (#1330)

* Add translations for French, Spanish

* Don't use import.meta.dirname in webpack.config.js (#1341)

* Don't use import.meta.dirname

Looks like `import.meta.dirname` was added in a point release in the Nodejs v20 series.

We are requiring "20" as a version, so some compatible versions won't work without this.

* Update variable name to appease linter

* remove exclude_from_nav and sitemap flags (#1340)

* Add State of Maryland (#1339)

* LG-14540: Update press kit (#1338)

* Add updated press kit

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/test-title-1.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/this-is-a-new-program-update-for-testing-purposes.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/this-is-a-new-program-update-for-testing-purposes.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/test-title-4444.md"

* Delete Program update “test-title-1”

* Delete Program update “test-title-4444”

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/re-run-circleci-tests.md"

* Create Program update “gsa’s-login-gov-expands-services-into-states” (#1350)

* Facilitate YML parsing of Time

* Facilitate YML parsing of Time

* Remove test entry

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/empowering-responsible-ai-the-ai-training-series-for-government-employees-is-currently-underway-read-all-about-it.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/esther-test.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/ponja-test-title.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "assets/img/screenshot-2024-10-23-at-11.12.48 am.png"
* "content/_program_updates/ponjas-second-test.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "assets/img/unnamed-2-.png"
* "assets/img/unnamed-3-.png"
* "assets/img/unnamed.png"
* "content/_program_updates/mobile-friendly-updates-to-identity-verification-workflow.md"

* Delete Program update “mobile-friendly-updates-to-identity-verification-workflow”

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/bug-bash-test-netlify-to-support-program-updates-pages.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/mobile-friendly-updates-to-identity-verification-workflow.md"

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/test-blog-post.md"

* Center images for program updates

* Hide initial launch

* Remove added content

* Reset config

* LG-14496: Chinese translation LQA fixes (#1342)

* 311 webpage section 1 (1/2)

* 311 webpage section 1 (2/2)

* 311 webpage section 2 (1/3)

* 311 webpage section 2 (2/3)

* 311 webpage section 2 (3/3)

* 311 webpage section 3 (1/1)

* LG-14499: More Chinese translation LQA fixes (#1343)

* Translation request 1 ("How to verify your identity" page)

* Translation request 2

How to verify your identity & how to verify your phone number pages

* Translation request 3

"Verify your address by mail" page

* changelog: User-Facing Improvements, chinese translations, updating alt text for verify photos chinese (#1363)

* LG-14190: Update contact us form topics (#1344)

*  Update contact us form topics

* LG-13951 Increase dependency version of @18f/identity-address-search to 3.2.0 to show error message for PO Search (#1362)

* Update version of @18f/identity-address-search

* Installed v3.2.0 of address-search

* Add translations for err msg

* Reinstalled address-search with diff node ver

* no change

* LG-14634: Remove SBA references (#1371)

* Remove SBA references

* Bump webrick from 1.8.1 to 1.8.2 (#1364)

Bumps [webrick](https://github.com/ruby/webrick) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/ruby/webrick/releases)
- [Commits](ruby/webrick@v1.8.1...v1.8.2)

---
updated-dependencies:
- dependency-name: webrick
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google-protobuf from 4.27.1 to 4.27.5 (#1334)

Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 4.27.1 to 4.27.5.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: google-protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* LG-14643 | "Verify your address by mail" updates (#1369)

* LG-13328: update translations for help center content (#1370)

* feat: update quotes on es translations

* feat: add non-breaking space to fr translations

* feat: delete character from chinese translations

* feat: add Find a Participating Post Office link for Chinese Translations

* Add PSHB to agencies dropdown (#1377)

Add PSHB to agencies dropdown

* Bump rexml from 3.3.6 to 3.3.9 (#1378)

Bumps [rexml](https://github.com/ruby/rexml) from 3.3.6 to 3.3.9.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.3.6...v3.3.9)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix redirected link for TOTP application (#1379)

* Use CircleCI orbs to install Node.js and Node/Ruby dependencies (#1383)

* Update email inputs (#1382)

* LG-14888: Update Spanish strings for LQA feedback (#1384)

* Add value FRB (#1386)

* LG-14959: Cleanup contact form (#1385)

* Cleanup contact form

* Update content for Security Check Failed per LQA (Chinese) (#1387)

* LG-14890: Update links on SAM.gov help center article (#1388)

* Update UEID link

* Update link "How do I become an entity administrator"

* Update "How do I update/renew an entity administration"

* Consolidate and update email links

* LG-14909: Update partner FAQ (#1389)

Update partner FAQ

* LG-14908: Add partner assurance level (#1390)

* Add partner assurance level page

* Update content/_partners/determining-your-assurance-level._en.md

Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>

* Change external link class

---------

Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>

* Update readme to  get mock data (#1392)

* LG-13653: Contact report security issue (#1381)

* Add "Report an Issue" to Contact Us page

* Bump cross-spawn from 7.0.3 to 7.0.6 (#1393)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* LG-15038: Update partners "our services" page (#1394)

* Add "our services" page to partners

Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>

---------

Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>

* Revert "Reset config"

This reverts commit 56d7af7.

* Create Program update “lorem-ipsum-odor-amet-consectetuer-adipiscing-elit” (#1403)

* Automatically generated. Merged on Netlify CMS

Force merge of:
* "content/_program_updates/gsa’s-bipartisan-infrastructure-law-projects-strengthen-safety-security-and-the-supply-chain-1.md"

* LG-11857: add header post office search results (#1391)

* feat: add resultsSectionHeading to post office search

* feat: add latest version of address-search package

* feat: add new results section heading content

* Add Microsoft & SSA domains to external URL ignore (#1395)

* Add apps.microsoft.com to external URL ignore

* Ignore faq.ssa.gov external domain errors

* LG-15062: Update TTS urls (#1399)

Update TTS urls

* LG-15065  Add new 'Issues with IPP' child page in Help Center (#1400)

* New Issues with IPP child page

* Update child order for chinese

* change urls to be root relative

* Change url to be root-relative and per language

* add trailing slash in relative url

* LG-15040: What is login (#1405)

* Update "what is login"

* add translations to issues with ipp (#1406)

* Revert "Revert "Reset config""

This reverts commit bdc9e4e.

* Remove test content

* LG-15181: Update header on partners page (#1407)

* Update header on "partners page"

* Move "State and local"

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matt Wagner <matt.wagner@gsa.gov>
Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
Co-authored-by: Kevin Masters <135744319+kevinsmaster5@users.noreply.github.com>
Co-authored-by: Akhlaq Khan <akhlaqkhan@users.noreply.github.com>
Co-authored-by: Esther Kim <163057060+esther2kim@users.noreply.github.com>
Co-authored-by: PonjaHO <106832142+PonjaHO@users.noreply.github.com>
Co-authored-by: allisonrosenberg <140114736+allisonrosenberg@users.noreply.github.com>
Co-authored-by: A Shukla <abir.shukla@gsa.gov>
Co-authored-by: Gina <125507397+gina-yamada@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: KeithNava <134446588+KeithNava@users.noreply.github.com>
Co-authored-by: Moncef Belyamani <monfresh@users.noreply.github.com>
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jc-gsa jc-gsa jc-gsa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@monfresh @jc-gsa