Conversation
aduth
approved these changes
Dec 18, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Did some light testing in the admin of the preview branch and locally with test articles, works well, LGTM 👍
Comment on lines
+130
to
+131
| values: | ||
| sitemap: false |
Contributor
There was a problem hiding this comment.
I'm assuming we'll want to remove this in the future once we have some articles?
Contributor
Author
There was a problem hiding this comment.
@aduth Yes, that's correct. Thank you for the reminder.
aduth
reviewed
Dec 19, 2024
| <!-- Include the script that builds the page and powers Netlify CMS --> | ||
| <script src="https://unpkg.com/netlify-cms@^2.0.0/dist/netlify-cms.js"></script> | ||
| <script> | ||
| const ProgramUpdatePreview = createClass({ |
Contributor
There was a problem hiding this comment.
If this is React, createClass was effectively deprecated in 2017 and later removed. It might save us some future refactoring if we made these function components from the start?
Contributor
Author
There was a problem hiding this comment.
There were a number of quirks for the preview component code for NetlifyCMS version 2.0.0. I believe this style, which I don't like, was written to match what I found in old documentation or address other limitations.
I'd upgrade to version 2.10.192 or 3.0 and then rewrite the preview components.
Force merge of: * "assets/img/450px.png" * "content/_program_updates/test-title-1.md"
* Cleanup contact form
* Update UEID link * Update link "How do I become an entity administrator" * Update "How do I update/renew an entity administration" * Consolidate and update email links
Update partner FAQ
* Add partner assurance level page * Update content/_partners/determining-your-assurance-level._en.md Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Change external link class --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* Add "Report an Issue" to Contact Us page
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add "our services" page to partners Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
This reverts commit 56d7af7.
Force merge of: * "content/_program_updates/gsa’s-bipartisan-infrastructure-law-projects-strengthen-safety-security-and-the-supply-chain-1.md"
* feat: add resultsSectionHeading to post office search * feat: add latest version of address-search package * feat: add new results section heading content
* Add apps.microsoft.com to external URL ignore * Ignore faq.ssa.gov external domain errors
Update TTS urls
* New Issues with IPP child page * Update child order for chinese * change urls to be root relative * Change url to be root-relative and per language * add trailing slash in relative url
* Update "what is login"
This reverts commit bdc9e4e.
* Update header on "partners page" * Move "State and local"
jc-gsa
force-pushed
the
LG-13755-program-updates
branch
from
ab35602 to
ca481d9
Compare
jc-gsa
added a commit
that referenced
this pull request
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13755
🛠 Summary of changes
Modify comments in
admin/config.ymlfor local development. To test on staging, I previously toggled the branch name inadmin/config.yml.For testing the interface, go to the location
/admin/#/collections/program_updates.📜 Testing Plan
The staging path can be found at the following URL. At the time of writing, the file
admin/config.ymlis not set for the staging branch.Alternatively, you can test on your local environment by modifying comments in the file
admin/config.ymland going to the corresponding/adminpath.