Merged
Conversation
added 12 commits
April 26, 2024 14:15
aduth
reviewed
Apr 26, 2024
_config.yml
Outdated
Comment on lines
+11
to
+12
| # Do not show Chinese in dropdown yet | ||
| # - zh |
Contributor
There was a problem hiding this comment.
This doesn't prevent it from being included in the sitemap and therefore more likely to be crawled & surfaced in search results. Per my previous point, I wonder if we could prevent the pages from being compiled at all in the live site or at least exclude from sitemap until we're ready?
Author
There was a problem hiding this comment.
I think the primary option there would be sitemap: false in the front matter, which isn't ideal?
mitchellhenke
force-pushed
the
mitchellhenke/chinese-translations
branch
from
21c42ab to
566f3be
Compare
mitchellhenke
force-pushed
the
mitchellhenke/chinese-translations
branch
2 times, most recently
from
b2c1211 to
27f83ce
Compare
mitchellhenke
force-pushed
the
mitchellhenke/chinese-translations
branch
from
27f83ce to
a368ac3
Compare
mitchellhenke
force-pushed
the
mitchellhenke/chinese-translations
branch
from
12fddfb to
1b3fdd4
Compare
mitchellhenke
force-pushed
the
mitchellhenke/chinese-translations
branch
from
1b3fdd4 to
453707a
Compare
aduth
previously approved these changes
Apr 30, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Approving since I assume this is a work-in-progress and there'll be ongoing iterations. Left a few comments for things I noticed.
content/_help/manage-your-account/change-your-email-address._zh.md
Outdated
Show resolved
Hide resolved
content/_help/verify-your-identity/accepted-identification-documents._zh.md
Outdated
Show resolved
Hide resolved
content/_help/verify-your-identity/how-to-add-images-of-your-state-issued-id._zh.md
Outdated
Show resolved
Hide resolved
content/_help/verify-your-identity/verify-your-identity-in-person._zh.md
Outdated
Show resolved
Hide resolved
.../verify-your-identity/verify-your-identity-in-person/find-a-participating-post-office._zh.md
Outdated
Show resolved
Hide resolved
…tate-issued-id._zh.md Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
…h.md Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
…uments._zh.md Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
added 2 commits
April 30, 2024 15:52
aduth
approved these changes
May 1, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
* Chinese translations --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
* Chinese translations --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
* Chinese translations --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
aduth
reviewed
May 21, 2024
| 程序员资源、实时支持、以及现代化工具来帮助你执行和部署自己在 Login.gov 的应用程序, | ||
|
|
||
|
|
||
| [参见开发人员指南]((https://developers.login.gov/){:class="why-more-info"} |
Contributor
There was a problem hiding this comment.
Looks like a syntax error here is preventing this from being rendered as a link.
Suggested change
| [参见开发人员指南]((https://developers.login.gov/){:class="why-more-info"} | |
| [参见开发人员指南](https://developers.login.gov/){:class="why-more-info"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Similar to 18F/identity-idp#10291, this PR adds the initial bulk translations for Chinese