Skip to content

LG-13107: Contact us form updates#1239

Merged
jc-gsa merged 8 commits intomainfrom
LG-13107-contact-form-updates
May 2, 2024
Merged

LG-13107: Contact us form updates#1239
jc-gsa merged 8 commits intomainfrom
LG-13107-contact-form-updates

Conversation

@jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Apr 29, 2024

🎫 Ticket

LG-13107

🛠 Summary of changes

This PR adds/updates the following agencies on the "contact us" form:

  • Get.gov
  • National Transportation Safety Board (NTSB)
  • State of California

A later update was made to the agency NTSB in French with the official State translation.

This PR also adds a hidden form field which was requested by Salesforce. The name of the language/translation of the site (with English, Spanish, and French supported for now) is added to the form field. The technical approach uses Jekyll's Liquid templating language to map the shortened language code to the full language name in English for Salesforce.

@jc-gsa jc-gsa requested review from a team May 1, 2024 17:22
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rebase / merge main to make sure there's no conflicts with #1237 ? Will this need Chinese translations?

@jc-gsa
Copy link
Contributor Author

jc-gsa commented May 1, 2024

Can we rebase / merge main to make sure there's no conflicts with #1237 ? Will this need Chinese translations?

I'll merge main.

This will not need Chinese translations for now, as I do not believe there are versions of the relevant emails in Chinese yet. If the value for the language is empty or invalid for any reason on the Salesforce side (despite an English fallback), the email will be sent in the default language of English.

@mitchellhenke
Copy link

This will not need Chinese translations for now, as I do not believe there are versions of the relevant emails in Chinese yet. If the value for the language is empty or invalid for any reason on the Salesforce side (despite an English fallback), the email will be sent in the default language of English.

If Salesforce will default to an English fallback, could we include Chinese anyway? If they add support for it, then we don't have to update here again in the future?

@jc-gsa jc-gsa merged commit 9ff651b into main May 2, 2024
@jc-gsa jc-gsa deleted the LG-13107-contact-form-updates branch May 2, 2024 15:29
mitchellhenke pushed a commit that referenced this pull request May 6, 2024
* Update agency names

* Add hidden language field to contact us form
mitchellhenke pushed a commit that referenced this pull request May 6, 2024
* Update agency names

* Add hidden language field to contact us form
mitchellhenke pushed a commit that referenced this pull request May 6, 2024
* Update agency names

* Add hidden language field to contact us form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants