Add CSI index support for BAM and VCF #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This looks good! My only gripe is that it's implemented in the old dojo style, so we are going to have to put in some extra work later to move it out into a node module. |
|
Would it be possible to support this for GFF3Tabix as well? this might allow for more informative feature density plots as you can set the step size for the index... |
|
@thomasvangurp Hopefully #1105 delivers support for CSI indexed GFF3Tabix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using CSI indexes on BAM and VCF
This allows doing coordinates of over a gigabase (or specifically 2^30 which is 1073741824)
It seems effective! The 64-bit bit manipulations are done using some floating point math specifically multiplying by two and dividing by two. A proper 64 bit math library could potentially be implemented.
Ref #926