sync main by ca333 · Pull Request #261 · GLEECBTC/komodo-defi-sdk-flutter

ca333 · 2025-10-26T20:15:54Z

logging
max conns

Summary by CodeRabbit

New Features
- Added configurable minimum and maximum connection parameters for protocol activation settings.
Tests
- Enhanced test mocking infrastructure for activation health monitoring.

more logging

coderabbitai · 2025-10-26T20:16:04Z

Caution

Review failed

The pull request is closed.

Walkthrough

This PR adds comprehensive logging infrastructure for activation operations across the Komodo DeFi SDK. It introduces activation parameter logging in RPC clients, extends ActivationRpcData with min/max connected fields, and embeds debug logging throughout protocol-specific activation strategies for observability.

Changes

Cohort / File(s)	Summary
RPC Client Activation Logging `packages/komodo_defi_framework/lib/komodo_defi_framework.dart`, `packages/komodo_defi_sdk/lib/src/client/kdf_api_client.dart`	Introduces `_isActivationMethod()` and `_logActivationParameters()` helpers to detect and log activation-related RPC methods before execution, capturing ticker, node counts, servers, RPC URLs, tokens, and contract details with safe-fail error handling.
Test Infrastructure `packages/komodo_defi_local_auth/test/src/trezor/trezor_auth_service_test.dart`	Adds `ensureKdfHealthy()` override and tracking fields (`ensureHealthyReturn`, `ensureHealthyCalls`) to `_FakeAuthService` for controlled test responses and invocation counting.
Activation Parameters `packages/komodo_defi_rpc_methods/lib/src/common_structures/activation/activation_params/activation_params.dart`	Extends `ActivationRpcData` constructor with `minConnected` and `maxConnected` fields (default `maxConnected=1`), adds validation asserts, and updates `fromJson` and `toJsonRequest` serialization.
Protocol Activation Strategy Logging `packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/{bch,custom_erc20,erc20,eth_task,eth_with_tokens,qtum,tendermint,utxo,zhtlc}_activation_strategy.dart`	Adds debug-level logging around activation procedures, including pre/post-call logs with JSON-encoded parameters (ticker, protocol, token counts, config details) and success confirmations; extracts activation parameters into local variables for clarity.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Review the activation parameter logging logic in RPC clients (_isActivationMethod, _logActivationParameters) for correctness and safe-fail semantics.
Verify ActivationRpcData field additions, validation asserts, and JSON serialization round-trip consistency.
Spot-check logging statements across multiple strategy files for consistency in parameter extraction and debug message formatting.

Possibly related PRs

sync main #257: Modifies executeRpc logging behavior in the same RPC client files.
fix(trezor): improve trezor error handling #110: Modifies ETH task-based activation strategies and related RPC types.
fix(trezor,activation): add PrivateKeyPolicy to AuthOptions #75: Touches activation parameter handling and PrivateKeyPolicy propagation.

Suggested labels

enhancement

Suggested reviewers

smk762
CharlVS

Poem

🐰 Activation logs now flow with care,
Each parameter tracked with rabbit flair,
Debug messages glow in strategic hue,
Tendermint, ETH, and UTXO too,
Observability blooms when the SDK's true! ✨

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch dev

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7197de6 and 17311fc.

📒 Files selected for processing (13)

packages/komodo_defi_framework/lib/komodo_defi_framework.dart (2 hunks)
packages/komodo_defi_framework/lib/src/client/kdf_api_client.dart (2 hunks)
packages/komodo_defi_local_auth/test/src/trezor/trezor_auth_service_test.dart (2 hunks)
packages/komodo_defi_rpc_methods/lib/src/common_structures/activation/activation_params/activation_params.dart (4 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/bch_activation_strategy.dart (3 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/custom_erc20_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/erc20_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_task_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_with_tokens_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/qtum_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/tendermint_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/utxo_activation_strategy.dart (2 hunks)
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/zhtlc_activation_strategy.dart (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull Request Overview

This PR adds debug logging for coin activation operations and introduces configuration for controlling electrum server connections. The changes enhance observability of activation processes and provide more control over server connectivity.

Adds comprehensive debug logging across all activation strategy implementations
Introduces min_connected and max_connected parameters for electrum server configuration
Implements activation parameter logging in API client layers
Adds test infrastructure for health check functionality

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
zhtlc_activation_strategy.dart	Adds debug logging for ZHTLC coin activation parameters
utxo_activation_strategy.dart	Adds debug logging for UTXO/Electrum activation with task tracking
tendermint_activation_strategy.dart	Adds debug logging for Tendermint platform activation
qtum_activation_strategy.dart	Adds debug logging for QTUM coin activation
eth_with_tokens_activation_strategy.dart	Adds debug logging for ETH platform activation with token support
eth_task_activation_strategy.dart	Adds debug logging for task-based ETH activation
erc20_activation_strategy.dart	Adds debug logging for ERC20 token activation
custom_erc20_activation_strategy.dart	Adds debug logging for custom ERC20 token activation
bch_activation_strategy.dart	Adds debug logging for BCH and SLP token activation
activation_params.dart	Adds min/max connected server configuration with validation
trezor_auth_service_test.dart	Adds test stub for ensureKdfHealthy method
kdf_api_client.dart	Implements activation parameter logging at API client level
komodo_defi_framework.dart	Implements activation parameter logging in framework layer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-26T20:16:36Z

      (forLightWallet ? 'electrum_servers' : 'servers'): electrum!
          .map((e) => e.toJsonRequest())
          .toList(),
+    if (electrum != null) 'max_connected': (maxConnected ?? 1),


The max_connected parameter is being included whenever electrum is not null, but it should only be included when explicitly set. This could send default values even when not intended. Change condition to if (maxConnected != null) to only include when explicitly provided.

Suggested change

if (electrum != null) 'max_connected': (maxConnected ?? 1),

if (maxConnected != null) 'max_connected': maxConnected,

Copilot · 2025-10-26T20:16:36Z

+      }
+    } catch (e) {
+      // Silently ignore logging errors
+      _logger.info('[ACTIVATION] Error logging parameters: $e');


Error logging uses info level instead of warning or error level. Change to _logger.warning('[ACTIVATION] Error logging parameters: $e'); to properly indicate this is an error condition.

Suggested change

_logger.info('[ACTIVATION] Error logging parameters: $e');

_logger.warning('[ACTIVATION] Error logging parameters: $e');

Copilot · 2025-10-26T20:16:36Z

+      }
+    } catch (e) {
+      // Silently ignore logging errors
+      _logger.fine('[ACTIVATION] Error logging parameters: $e');


Error logging uses fine level instead of warning or error level. Change to _logger.warning('[ACTIVATION] Error logging parameters: $e'); to properly indicate this is an error condition.

Suggested change

_logger.fine('[ACTIVATION] Error logging parameters: $e');

_logger.warning('[ACTIVATION] Error logging parameters: $e');

github-actions · 2025-10-26T20:20:44Z

Visit the preview URL for this PR (updated for commit 17311fc):

https://kdf-sdk--pr261-dev-7ni5xs9c.web.app

_{(expires Sun, 02 Nov 2025 20:20:39 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d}

github-actions · 2025-10-26T20:21:20Z

Visit the preview URL for this PR (updated for commit 17311fc):

https://komodo-playground--pr261-dev-528l63z8.web.app

_{(expires Sun, 02 Nov 2025 20:21:15 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47}

ca333 and others added 4 commits October 26, 2025 18:20

more logging

9ff3ab0

add missing func to test mock class

b1af397

Merge pull request #258 from KomodoPlatform/more_logging

c076237

more logging

fix max conns & enhance logging

17311fc

Copilot AI review requested due to automatic review settings October 26, 2025 20:15

ca333 merged commit 49fac52 into main Oct 26, 2025
6 of 9 checks passed

Copilot AI reviewed Oct 26, 2025

View reviewed changes

This was referenced Oct 27, 2025

sync main #265

Merged

add optional verbose logging #278

Merged

sync main #279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sync main#261

sync main#261
ca333 merged 4 commits intomainfrom
dev

ca333 commented Oct 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 26, 2025 •

edited

Loading

Review failed

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 26, 2025

Uh oh!

Copilot AI Oct 26, 2025

Uh oh!

Copilot AI Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (electrum != null) 'max_connected': (maxConnected ?? 1),
	if (maxConnected != null) 'max_connected': maxConnected,

	_logger.info('[ACTIVATION] Error logging parameters: $e');
	_logger.warning('[ACTIVATION] Error logging parameters: $e');

	_logger.fine('[ACTIVATION] Error logging parameters: $e');
	_logger.warning('[ACTIVATION] Error logging parameters: $e');

Conversation

ca333 commented Oct 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ca333 commented Oct 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 26, 2025 •

edited

Loading