Skip to content

more logging#258

Merged
ca333 merged 2 commits intodevfrom
more_logging
Oct 26, 2025
Merged

more logging#258
ca333 merged 2 commits intodevfrom
more_logging

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Oct 26, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 26, 2025 17:33
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch more_logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive debug logging across all coin activation strategies to track RPC calls and their parameters during the activation process.

Key Changes:

  • Added structured logging at key points in each activation strategy (before RPC calls, after task initiation)
  • Refactored inline parameter construction to named variables for better readability and logging access
  • Added a mock implementation for the ensureKdfHealthy method in test utilities

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
zhtlc_activation_strategy.dart Added logging for ZHTLC coin activation parameters and task initiation
utxo_activation_strategy.dart Added logging for UTXO/Electrum activation with detailed protocol parameters
tendermint_activation_strategy.dart Added logging for Tendermint platform activation including token details
qtum_activation_strategy.dart Added logging for QTUM activation parameters and task tracking
eth_with_tokens_activation_strategy.dart Added logging for ETH platform activation with token counts
eth_task_activation_strategy.dart Added logging for task-based ETH activation
erc20_activation_strategy.dart Added logging for ERC20 token activation
custom_erc20_activation_strategy.dart Added logging for custom ERC20 token activation with contract details
bch_activation_strategy.dart Added logging for BCH platform and SLP token activation
trezor_auth_service_test.dart Added mock implementation tracking for ensureKdfHealthy method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ca333 ca333 merged commit c076237 into dev Oct 26, 2025
3 of 4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit b1af397):

https://komodo-playground--pr258-more-logging-2d9hm9l2.web.app

(expires Sun, 02 Nov 2025 17:38:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit b1af397):

https://kdf-sdk--pr258-more-logging-k3r9srlc.web.app

(expires Sun, 02 Nov 2025 17:38:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants