fix(trezor): improve trezor error handling#110
Merged
Conversation
fixes the following scenarios - trezor device not found - trezor device not selected and other edge cases that may cause trezor init or auth to fail, ensuring that the user already exists error is not thrown
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update introduces new Ethereum activation strategies, refactors Trezor authentication logic, and standardizes private key policy handling across activation strategies. It adds new classes and methods for ETH task-based activation, updates protocol strategy exports, removes legacy batch activation logic, and adjusts dependencies and documentation in multiple packages. Changes
Sequence Diagram(s)sequenceDiagram
participant UI
participant SDK
participant RPC
participant HW (Trezor)
UI->>SDK: activate(Asset, [children])
alt ETH platform asset with Trezor
SDK->>RPC: erc20.enableEthInit (with params)
SDK->>HW: Interact with Trezor device
loop Polling task status
SDK->>RPC: erc20.taskEthStatus(taskId)
RPC-->>SDK: Task status/progress
end
SDK-->>UI: ActivationProgress (success/failure)
else ETH platform asset (non-Trezor)
SDK->>RPC: enableEthWithTokens (with params)
SDK-->>UI: ActivationProgress (success)
else ERC20 token
SDK->>RPC: enableErc20 (with params)
SDK-->>UI: ActivationProgress (success)
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/komodo_defi_framework/pubspec.yaml (1)
31-31: Good dependency bump, but consider tightening with a<2.0.0upper bound.
loggingis a stable core package yet still at major1. Adding an upper bound (<2.0.0) protects against an eventual breaking 2.0 release that could land unexpectedly and break your CI.- logging: ^1.3.0 + logging: '>=1.3.0 <2.0.0'packages/komodo_wallet_build_transformer/pubspec.yaml (1)
16-16: Keep dependency ranges consistent with the other packages.If you adopt the
<2.0.0upper-bound advice inkomodo_defi_framework, mirror it here to keep constraint solving deterministic across all packages.packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/utxo_activation_strategy.dart (1)
8-10: Doc comment added – 👍 but constructor param lacks matching comment.Nice clarification on
privKeyPolicy. For full IDE tooltip symmetry, consider documenting the constructor parameter as well:-const UtxoActivationStrategy(super.client, this.privKeyPolicy); +/// Creates a UTXO activation strategy with the given [client] and +/// [privKeyPolicy] that dictates how private keys are handled, e.g. for +/// external wallets such as Trezor. +const UtxoActivationStrategy(super.client, this.privKeyPolicy);packages/komodo_defi_rpc_methods/lib/src/rpc_methods/eth/eth_rpc_extensions.dart (1)
53-71: LGTM: Well-implemented task-based ETH RPC methods.The new methods follow established patterns and correctly implement the task-based ETH activation flow. The implementation properly handles RPC password passing and uses appropriate request types.
Consider adding documentation comments for the new methods to match the existing code style:
+ /// Initiates an ETH enablement task for Trezor/hardware wallet support Future<NewTaskResponse> enableEthInit({ required String ticker, required EthWithTokensActivationParams params, }) { // ... existing implementation } + /// Queries the status of an ETH enablement task Future<TaskStatusResponse> taskEthStatus(int taskId, [String? rpcPass]) { // ... existing implementation }packages/komodo_defi_rpc_methods/lib/src/rpc_methods/eth/task_enable_eth_init.dart (1)
11-14: Remove unnecessary ignore comment.The
// ignore: overridden_fieldscomment appears to be unnecessary asparamsis not overriding any field from the base classBaseRequest.- @override - // ignore: overridden_fields final EthWithTokensActivationParams params;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (19)
packages/komodo_defi_framework/pubspec.yaml(1 hunks)packages/komodo_defi_local_auth/lib/src/trezor/trezor_auth_service.dart(9 hunks)packages/komodo_defi_local_auth/pubspec.yaml(1 hunks)packages/komodo_defi_rpc_methods/lib/src/common_structures/activation/activation_params/tendermint_activation_params.dart(4 hunks)packages/komodo_defi_rpc_methods/lib/src/rpc_methods/eth/eth_rpc_extensions.dart(1 hunks)packages/komodo_defi_rpc_methods/lib/src/rpc_methods/eth/task_enable_eth_init.dart(1 hunks)packages/komodo_defi_rpc_methods/lib/src/rpc_methods/rpc_methods.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/_activation.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/_activation_index.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/base_strategies/activation_strategy_factory.dart(2 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/erc20_activation_strategy.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_task_activation_strategy.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_with_tokens_activation_strategy.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_with_tokens_batch_strategy.dart(0 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/qtum_activation_strategy.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/tendermint_activation_strategy.dart(3 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/utxo_activation_strategy.dart(1 hunks)packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/zhtlc_activation_strategy.dart(3 hunks)packages/komodo_wallet_build_transformer/pubspec.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_with_tokens_batch_strategy.dart
🧰 Additional context used
🧠 Learnings (2)
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/rpc_methods.dart (1)
Learnt from: takenagain
PR: KomodoPlatform/komodo-defi-sdk-flutter#70
File: packages/komodo_defi_rpc_methods/lib/src/rpc_methods/swaps/legacy/cancel_order.dart:8-9
Timestamp: 2025-06-02T12:44:56.953Z
Learning: Legacy RPC methods in the Komodo DeFi SDK (located in `/legacy/` subdirectories) intentionally use `mmrpc: null` in their constructors, unlike modern RPC methods that use `mmrpc: "2.0"`. This is by design and should not be changed to maintain backward compatibility.
packages/komodo_defi_rpc_methods/lib/src/common_structures/activation/activation_params/tendermint_activation_params.dart (1)
Learnt from: takenagain
PR: KomodoPlatform/komodo-defi-sdk-flutter#70
File: packages/komodo_defi_rpc_methods/lib/src/rpc_methods/swaps/legacy/cancel_order.dart:8-9
Timestamp: 2025-06-02T12:44:56.953Z
Learning: Legacy RPC methods in the Komodo DeFi SDK (located in `/legacy/` subdirectories) intentionally use `mmrpc: null` in their constructors, unlike modern RPC methods that use `mmrpc: "2.0"`. This is by design and should not be changed to maintain backward compatibility.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build_and_preview_playground_preview
- GitHub Check: build_and_preview_sdk_example_preview
🔇 Additional comments (30)
packages/komodo_defi_local_auth/pubspec.yaml (1)
30-30: Confirm workspace-wide alignment onlogging ^1.3.0.
logging: ^1.3.0is now declared here. Please double-check that every other package in the mono-repo (including the root Flutter app, if any) also pinsloggingto a compatible^1.3.0range. A stray^1.2.xelsewhere will cause a version-solve failure.A quick
grep -R "logging:"ordart pub outdatedin the root will surface mismatches.packages/komodo_defi_rpc_methods/lib/src/rpc_methods/rpc_methods.dart (1)
20-20: Export target verified and included
- The file
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/eth/task_enable_eth_init.dartexists.- It’s referenced in
eth_rpc_extensions.dartand used viaenableEthInit()in the SDK.- Dart’s default pub behavior includes all files under
lib/, so no additional pubspec changes are needed.packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/qtum_activation_strategy.dart (1)
8-9: LGTM: Good documentation improvement.The added documentation clearly explains the purpose of the
privKeyPolicyfield and its relevance for external wallet support.packages/komodo_defi_sdk/lib/src/activation/_activation.dart (1)
14-15: Batch strategy removal verifiedNo references to
EthWithTokensBatchStrategyoreth_with_tokens_batch_strategyremain in the codebase. The export changes in_activation.dartcan be approved.• packages/komodo_defi_sdk/lib/src/activation/_activation.dart (lines 14–15) [exports updated]
• Ranrg -i "eth_with_tokens_batch_strategy|EthWithTokensBatchStrategy" --type dart→ no matches foundpackages/komodo_defi_sdk/lib/src/activation/_activation_index.dart (1)
14-15: LGTM: Consistent export changes.The export changes match those in
_activation.dart, maintaining consistency across the generated index files.packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/zhtlc_activation_strategy.dart (3)
9-11: LGTM: Consistent privKeyPolicy integration.The constructor and field addition follow the established pattern for private key policy support across activation strategies.
45-52: LGTM: Proper parameter integration.The
privKeyPolicyis correctly integrated into the activation parameters usinggenericCopyWith, maintaining consistency with the existing parameter handling pattern.
71-71: LGTM: Improved code formatting.The formatting improvement makes the
TaskEnableZhtlcInitcall more readable.packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/tendermint_activation_strategy.dart (1)
6-8: LGTM! Proper integration ofprivKeyPolicyparameter.The changes correctly implement the private key policy support:
- Constructor properly accepts and stores the parameter
- Policy is correctly passed to both platform activation (line 77) and token activation (line 92)
- Consistent with the pattern across other activation strategies
Also applies to: 69-78, 92-92
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/eth/task_enable_eth_init.dart (1)
1-32: Well-structured RPC request implementation.The
TaskEnableEthInitclass is properly implemented:
- Extends
BaseRequestwith correct response types- Proper JSON serialization in
toJsonmethod- Correct error handling in
parseResponse- Follows established RPC request patterns
packages/komodo_defi_sdk/lib/src/activation/base_strategies/activation_strategy_factory.dart (1)
7-32: Excellent factory refactoring with comprehensive documentation.The changes properly integrate
privKeyPolicyacross all activation strategies:
- Clear documentation explaining the purpose and parameters
- Consistent parameter passing to all strategies
- Proper integration of new ETH-related strategies
- Maintains clean factory pattern
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_with_tokens_activation_strategy.dart (1)
1-139: Well-designed activation strategy with comprehensive protocol support.The
EthWithTokensActivationStrategyimplementation is excellent:
- Properly excludes Trezor policy (handled by
EthTaskActivationStrategy)- Supports extensive list of EVM-compatible protocols
- Clear progress reporting with detailed step information
- Robust error handling with stack traces
- Proper batch activation support for platform assets with tokens
packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/erc20_activation_strategy.dart (2)
35-41: Good separation of concerns between token and platform activation.The
canHandlemethod correctly:
- Restricts to token assets only (with parent ID)
- Excludes Trezor policy (handled by
EthTaskActivationStrategy)- Properly throws error if batch activation is attempted
This creates a clear separation where:
Erc20ActivationStrategy: Handles individual token activation (non-Trezor)EthWithTokensActivationStrategy: Handles platform with batch token activation (non-Trezor)EthTaskActivationStrategy: Handles Trezor-specific activationAlso applies to: 48-50
31-32: No impact from disabling ERC20 batch activation
We searched the codebase for any references tosupportsBatchActivationor ERC20 batch flows—including tests—and found none outside of this strategy implementation. Disabling batch activation for ERC20 is safe and won’t break existing functionality.packages/komodo_defi_rpc_methods/lib/src/common_structures/activation/activation_params/tendermint_activation_params.dart (4)
11-13: LGTM! Good refactoring of parameter handling.The changes to pass these parameters to the super constructor improve consistency and reduce code duplication.
16-19: Well-structured factory method enhancement.The optional
privKeyPolicyparameter with proper fallback logic enables flexible initialization while maintaining backward compatibility.Also applies to: 38-38
83-86: Consistent private key policy serialization.The serialization correctly converts the policy to PascalCase format with a sensible default value.
92-117: Consistent implementation across both activation parameter classes.The changes to
TendermintTokenActivationParamscorrectly mirror the pattern established in the parent class, ensuring uniform private key policy handling.packages/komodo_defi_sdk/lib/src/activation/protocol_strategies/eth_task_activation_strategy.dart (5)
5-39: Well-designed strategy class for Trezor Ethereum activation.The class structure is clean with appropriate protocol support and clear constraints for Trezor-only handling.
41-70: Comprehensive initialization with detailed progress tracking.The activation method provides excellent user feedback with structured progress details and appropriate validation steps.
71-144: Robust task-based activation with appropriate polling.The implementation correctly handles the asynchronous nature of Trezor activation with proper status checking and user feedback. The 500ms polling interval is reasonable for hardware wallet operations.
145-159: Excellent error handling with detailed diagnostics.The error handling captures full context including stack traces, which will be valuable for debugging hardware wallet issues.
161-214: Comprehensive status mapping for user feedback.The
_parseEthStatusmethod provides detailed, user-friendly status messages with appropriate progress indicators. The default case ensures graceful handling of unexpected statuses.packages/komodo_defi_local_auth/lib/src/trezor/trezor_auth_service.dart (7)
7-7: Good addition of logging capability.Adding the logger will help with debugging Trezor authentication issues.
Also applies to: 23-23
39-61: Excellent refactoring to eliminate code duplication.Both stream methods now share common logic through
_authenticateTrezorStream, improving maintainability while preserving error handling with automatic sign-out.
119-139: Clean refactoring of synchronous authentication methods.The
signInmethod now delegates to the common helper while maintaining proper error handling and sign-out on failure.
147-167: Consistent implementation for registration.The
registermethod mirrors thesignInimplementation, ensuring consistent behavior across authentication methods.
215-243: Smart refactoring of authentication logic.The method now internally determines whether to register or sign in based on existing user presence, reducing complexity and potential for misuse.
278-309: Well-structured stream-based authentication helper.The method properly handles all authentication states and ensures cleanup on errors or cancellation.
320-369: Comprehensive passphrase-based authentication implementation.The method correctly handles passphrase provision, ignores PIN prompts (as documented), and ensures proper cleanup on all error paths. The detailed documentation is particularly helpful.
) * feat(asset-manager): asset filter strategy based on current wallet * featasset-manager): limit trezor asset filter to utxo and qtum only * refactor: add error response check and evm subclasses set coderabbitai suggestions * feat: add name-based filter strategy (#108) * refactor: update authOptions references to use walletId * refactor(asset-filter): rename `name` to `strategyId`
Contributor
|
Visit the preview URL for this PR (updated for commit 6b10720): https://komodo-defi-sdk--pr110-fix-trezor-auth-exce-gpe6431p.web.app (expires Tue, 08 Jul 2025 21:35:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347 |
CharlVS
added a commit
that referenced
this pull request
Aug 5, 2025
commit 0303d39 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Fri Aug 1 15:52:14 2025 +0200 chore: switch KDF to `dev` Switch KDF to `dev` to allow usage of unreleased changes (particularly related to fees/priorities) commit 1fae456 Author: Francois <takenagain@users.noreply.github.com> Date: Fri Aug 1 17:46:34 2025 +0200 fix(market-data-price): try fetch current price from komodo price repository first before cex repository (#167) * fix(market-data-manager): default to KomodoPriceRepository Binance CexRepository supports a limited number of symbols and no longer lists KMD price history after the delisting * refactor(market-data-manager): deduplicate and clarify intent * refactor(review): remove zero check and add log statements also simplify the priceIfKnown function commit f8064f2 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Fri Aug 1 15:50:09 2025 +0200 fix(types): comprehensive bip39 validation commit 60e5f2e Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 30 21:18:06 2025 +0200 feat: offline private key export (#160) * feat(hd): integrate hd privkey export * chore: roll KDF * chore: enable tendermint hd support * refactor(rpc): Misc rpc class formats/fixes * feat: private keys + fixed Tendermint * refactor(sdk): implement co-ordinated activation manager * fix: invalid path error Possible fix for paths containing special characters on Windows. * fix: remove unnecessary activation logging * chore(pr): apply formatting and fixes to PR Apply Dart formatting and fixes to all files modified in this PR. * feat(example): integrate private key export to example app * chore: roll KDF * chore: roll KDF * feat: fee estimation * fix(build): make re-build failure stand out * chore: roll KDF Roll KDF for optimisation for key export time. * feat(tx): further progress on fee/priority integration * chore: roll KDF fro `v2.6.1` TODO: Change from CI builds to GitHub release when artefacts are available. * fix(api): disable fee/priority features Disable fee/priority features because they are not included in the pending KDF release. They should be included in the following release (likely `2.7.0`) * fix: Temporarily disable fee/priority features Temporarily disable fee/priority features until the feature is available in the API (KDF) * feat: add memo support protocol value * fix: resolve incorrect `unban_pubkeys` parsing * fix: resolve regression in legacy withdrawal manager * feat(security): Include failed activations in privkey export * docs(build): expand asset build failure explination * fix: tweak private key type json to match class properties * fix(RPC): fix new address generation types * chore: bump version tags * fix: apply Claude PR review suggestions commit 834b83f Merge: 1526a23 a41f81f Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 30 20:12:37 2025 +0200 Merge pull request #165 from KomodoPlatform/migrate/dragon_logs_flutter feat: migrate dragon_logs_flutter to monorepo packages commit a41f81f Merge: 1526a23 a6a9a6e Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 30 18:19:07 2025 +0200 Merge commit 'a6a9a6ef4a308f95be1fafbb018449f198d8b4db' as 'packages/dragon_logs' commit a6a9a6e Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 30 18:19:07 2025 +0200 Squashed 'packages/dragon_logs/' content from commit 399ef1d1 git-subtree-dir: packages/dragon_logs git-subtree-split: 399ef1d17034029155b63b6bc1d9ab0a5a0fbb04 commit 1526a23 Merge: dc093db acda1d9 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 28 21:10:37 2025 +0200 Merge branch 'codex/implement-pubkey-unbanning-feature' into dev commit acda1d9 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 28 21:07:58 2025 +0200 fix(ui): resolve stale asset balance widget commit dc093db Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 28 20:18:02 2025 +0200 feat(pubkeys): add unbanning support (#161) * feat(pubkeys): add unbanning support * Update packages/komodo_defi_rpc_methods/lib/src/rpc_methods/wallet/unban_pubkeys.dart Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(types): export missing RPC types --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 7d7e888 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 28 20:14:54 2025 +0200 fix(types): export missing RPC types commit 9621aa2 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 28 20:00:48 2025 +0200 Update packages/komodo_defi_rpc_methods/lib/src/rpc_methods/wallet/unban_pubkeys.dart Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 4a3d9c8 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 28 18:33:47 2025 +0200 feat(pubkeys): add unbanning support commit b18af0b Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Sun Jul 27 16:59:11 2025 +0200 feat(ui): add hero support for coin icons (#159) * feat(ui): add hero support for asset icons * fix(ui): Hero Tag Ignored in AssetLogo Placeholder * fix: Move Hero widget outside Opacity widget for proper animation continuity - Fix AssetLogo.placeholder to pass heroTag parameter to _AssetLogoPlaceholder - Move Hero widget outside Opacity widget in AssetIcon to prevent animation interference - Ensures Hero animations work correctly for both asset icons and placeholder logos - Maintains visual continuity by placing Hero widgets as outermost components commit c2d985a Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Fri Jul 25 15:20:29 2025 +0200 feat(fees): integrate fee management (#152) * feat(fees): add fee management support * docs(sdk): Document withdrawal manager Document withdrawal manager and implement PR review comments. * docs(sdk): Add documentation for fee manager commit e1a63e2 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Fri Jul 25 11:15:26 2025 +0200 feat(activation): disable tx history when using external strategy (#151) * feat(activation): disable kdf tx history when using external strategy * docs: clarify mm2 history helper (#154) commit 74d8eff Author: Francois <takenagain@users.noreply.github.com> Date: Thu Jul 24 18:30:54 2025 +0200 Revert "fix(activation): track activation status to avoid duplicate activation requests (#80)" (#153) This reverts commit abd3de0. commit 7eefbd8 Author: dragonhound <35845239+smk762@users.noreply.github.com> Date: Mon Jul 21 20:24:39 2025 +0800 adds `max_connected: 1` to utxo activation (#148) commit b8ff967 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 21 14:24:16 2025 +0200 Revert "feat(rpc): support max_connected on activation (#149)" (#150) This reverts commit eac2b8f. commit eac2b8f Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 21 13:11:54 2025 +0200 feat(rpc): support max_connected on activation (#149) * feat(rpc): support max_connected on activation * fix: limit max connections to 1 commit bb57e87 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Sun Jul 20 00:15:49 2025 +0200 fix(build): update config format commit 6534d47 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Sun Jul 20 00:04:09 2025 +0200 feat(wallet_build_transformer): add flexible CDN support (#144) commit abd3de0 Author: Francois <takenagain@users.noreply.github.com> Date: Thu Jul 17 18:54:01 2025 +0200 fix(activation): track activation status to avoid duplicate activation requests (#80) * Track activation streams to avoid duplicate requests * fix activation stream propagation * fix(activation): provide historical states to late stream subscribers * fix(activation): use asset lookup in parent grouping using the asset itself as a placeholder led to assertion errors being thrown if the child asset is activated individually. commit 9351c22 Author: Francois <takenagain@users.noreply.github.com> Date: Wed Jul 16 19:55:00 2025 +0200 feat(ui): allow customizing SourceAddressField header (#135) * feat(ui): make source address field customizable * refactor: remove content override from SourceAddressField commit a521a80 Author: Francois <takenagain@users.noreply.github.com> Date: Wed Jul 16 14:37:28 2025 +0200 fix(withdraw): revert temporary IBC channel type changes (#136) #63 commit a44acf3 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 14 16:14:45 2025 +0200 fix(ui): make Divided button min width commit aa51985 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jul 7 17:15:04 2025 +0200 feat: protect SDK after disposal (#116) * feat: prevent SDK reuse after disposal * refactor(sdk): promote dispose helper (#127) commit 9cf9e37 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 7 15:08:29 2025 +0200 chore: roll KDF version to commit fbab8ec for branch main (#124) * chore: roll KDF version to commit fbab8ec for branch main * chore: update binaries * chore: roll coins assets --------- Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: CharlVS <77973576+CharlVS@users.noreply.github.com> commit ce68c7a Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Sat Jul 5 19:24:33 2025 +0200 feat(seed): update seed node format (#87) * feat(seed): update seed node format with netid * Update packages/komodo_defi_types/lib/src/seed_node/seed_node.dart Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(core): use constant netid in seed node filtering (#111) * fix: add missing imports/exports --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit d7b6ede Author: Francois <takenagain@users.noreply.github.com> Date: Sat Jul 5 18:37:15 2025 +0200 feat(pubkey): add streamed new address API with Trezor confirmations (#123) * feat(pubkey): add streamed new address API with Trezor confirmations (#117) * Implement streamed new address state with confirmations * refactor: remove unused imports and make polling interval configurable * refactor: move confirm address details to types (#120) * refactor: move confirm address details to types * refactor: fix warnings * feat(example): use streamed address creation (#119) * Use streamed address generation * refactor: add cancel action and use normal stream rather than broadcast * chore: add json conversion support to `NewAddressState` * fix(asset-filter): exclude BCH and yield address creation error states * refactor: add task description parser and try cancel task if user cancel commit d6d83c6 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Fri Jul 4 18:30:50 2025 +0200 fix(local_auth): ensure kdf running before wallet deletion (#118) commit cda8498 Author: Francois <takenagain@users.noreply.github.com> Date: Thu Jul 3 20:44:32 2025 +0200 feat(ui): add helper constructors for AssetLogo from legacy ticker and AssetId (#109) * feat(ui): add AssetLogo constructors * fix: correct protocol overlay for child assets (#115) * fix(example): use parent protocol for child assets in trailing icon * feat(ui): add placeholder asset logo used in legacy maker and taker forms in KW * feat(ui): add asset exists helper functions used in KW fiat onramp form * refactor: clarify doc comments and rename constructors * fix(assets): tendermint token parent parsing logic - place tendermint before tendermint token - replace subclass check with canBeParentOf * refactor(asset-logo): use theme `disabledColor` in place of Opacity --------- Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> commit 3dc37d0 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Thu Jul 3 19:16:58 2025 +0200 add(ui): enhance TrendPercentageText Enhance `TrendPercentageText` with expanded use cases and automatic animations. commit c5c30d4 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 2 18:45:02 2025 +0200 fix: resolve bug with dispose logic TODO(@CharlVS): Consider separating the KDF-related concerns of dispose into a separate method named terminate(). This helps differentiate between KDF resource clean-up and UI resource clean-up commit 9d63c56 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 2 15:34:14 2025 +0200 add(auth): auth stream method with initial value commit 81ba643 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 2 11:09:33 2025 +0200 fix: stop KDF when disposed commit c8f27a7 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Wed Jul 2 10:33:27 2025 +0200 fix: SIA support Disable SIA as it is not yet supported. The SIA activation strategy will be merged soon, but this depends on a specific branch of KDF and will likely still be very long before it is available in a public release of KDF. commit a02c4a2 Author: Francois <takenagain@users.noreply.github.com> Date: Wed Jul 2 09:48:09 2025 +0200 fix(trezor): improve trezor error handling (#110) * chore(deps): bump logging version to 1.3.0 as in komodo-wallet * fix(trezor): sign out of existing wallet if initialisation fails fixes the following scenarios - trezor device not found - trezor device not selected and other edge cases that may cause trezor init or auth to fail, ensuring that the user already exists error is not thrown * feat(trezor): add priv_key_policy to tendermint, erc20, and zhtlc params * fix(trezor): yield error states rather than exceptions in streams * feat(activation,rpc): task-based eth activation * feat(asset-manager): asset filter strategy based on current wallet (#107) * feat(asset-manager): asset filter strategy based on current wallet * featasset-manager): limit trezor asset filter to utxo and qtum only * refactor: add error response check and evm subclasses set coderabbitai suggestions * feat: add name-based filter strategy (#108) * refactor: update authOptions references to use walletId * refactor(asset-filter): rename `name` to `strategyId` * ci(example): re-enable dry build run commit 8a1daea Author: Francois <takenagain@users.noreply.github.com> Date: Wed Jul 2 09:45:18 2025 +0200 feat(ui): adjust error display layout for narrow screens (#114) * chore(deps): bump logging version to 1.3.0 as in komodo-wallet * fix(trezor): sign out of existing wallet if initialisation fails fixes the following scenarios - trezor device not found - trezor device not selected and other edge cases that may cause trezor init or auth to fail, ensuring that the user already exists error is not thrown * feat(trezor): add priv_key_policy to tendermint, erc20, and zhtlc params * fix(trezor): yield error states rather than exceptions in streams * feat(activation,rpc): task-based eth activation * feat(asset-manager): asset filter strategy based on current wallet (#107) * feat(asset-manager): asset filter strategy based on current wallet * featasset-manager): limit trezor asset filter to utxo and qtum only * refactor: add error response check and evm subclasses set coderabbitai suggestions * feat: add name-based filter strategy (#108) * refactor: update authOptions references to use walletId * refactor(asset-filter): rename `name` to `strategyId` * refactor: extract show details button * Refactor error display components * refactor: convert toggle to stateless widget * feat(ui): add toggle for icon and expose breakpoint * fix(ui): button interactivity no-op when showDetailsOverride is true Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor: remove unnecessary spread operator --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 5f7da9e Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 30 15:34:29 2025 +0200 ci: skip melos init Disabled melos generation due to circular dependency issues caused by komodo_defi_rpc_methods and komodo_defi_types packages. This will be revisited in the. The app should already have the necessary generated files committed to the repository. If this is not the case, we have bigger issues. commit f6f5820 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 30 15:25:59 2025 +0200 add: Wallet deletion example and fix global error parsing flaw (#99) * feat(auth): add wallet deletion * feat(example): add wallet deletion * add: wallet deletion for Trezor wallets * chore: re-generate melos * refactor: fix flaw in response error parsing Fix flaw in response error parsing where the custom error parser function would never be called because of the inheritence structure. * feat(example): move delete wallet action (#104) commit fafc707 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 30 14:57:00 2025 +0200 feat(asset): add message signing support flag (#105) commit 3701f49 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 30 14:41:23 2025 +0200 fix: kdf hashes commit a2face7 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 30 14:16:56 2025 +0200 chore(kdf): update build config to latest staging (#103) commit 41fb498 Author: Francois <takenagain@users.noreply.github.com> Date: Mon Jun 30 11:45:18 2025 +0200 chore(deps): bump komodo-defi-framework to a25aea614 (#102) latest staging with hotfix for trezor coin activation commit 7dfe68b Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Fri Jun 27 14:58:42 2025 +0200 chore: roll KDF (#100) commit e5d022b Author: Francois <takenagain@users.noreply.github.com> Date: Thu Jun 26 16:41:13 2025 +0200 fix(pubkey-strategy): use new PrivateKeyPolicy constructors for checks (#97) commit 24d09fd Author: Francois <takenagain@users.noreply.github.com> Date: Wed Jun 25 16:08:18 2025 +0200 fix(activation): eth PrivateKeyPolicy enum breaking changes (#96) * fix(rpc,activation): breaking EVM private key policy enum change * fix(activation-params): use pascal case for to and from json * test(example): add asset activation integration test * test(example): run in zone to catch microtask and uncaught exceptions * fix(auth): merge issues and update privkeypolicy comparisons * docs: expand doc comments and remove runzonedguarded commit 2a50691 Author: Francois <takenagain@users.noreply.github.com> Date: Tue Jun 24 18:52:35 2025 +0200 feat(sdk): add trezor support via RPC and SDK wrappers (#77) * fix(trezor,activation): add PrivateKeyPolicy to AuthOptions and beyond * feat(rpc): add trezor init task RPCs * feat(sdk): trezor manager for init and user input requests * feat(rpc): add task-based address generation RPCs * feat(rpc): add trezor pubkey strategy with task-based address creation * WIP: trezor login option in SDK example * refactor(example): trezor auth mixin and remove previous trezor ui code * fix(trezor): device info parsing and example auth state transitions * refactor(trezor): add auth listener & implement coderabbitai suggestions * fix(example): auth restoration and listener order * fix(trezor): workaround for trezor-specifc scan issue funded addresses not being scanned for fresh trezor logins (maybe not believed to be a "fresh" wallet)? * fix(rpc): get new address task status response parsing * refactor(trezor): move authentication and initialization logic to SDK (#81) This is a concept solution that moves the Trezor initialization and authentication flow from the example BLoC to the SDK KomodoDefiAuth class & package. Two issues that make integrating the trezor login flow with the current SDK difficult: - Trezor login is a multi-step process that uses task-based RPCs, so Stream-based versions of the signin and register methods are required. - Async user inputs (i.e. passphrase or pin) need to be sent to trezor as part of login process. Solution implemented in this PR: - Add stream-based signInStream and registerStream functions to KomodoDefiAuth with a new Authentication state/status class. - Alternative (breaking): modify the existing functions to return Stream - Add input methods for passphrase and pin to KomodoDefiAuth - Alternative 1: Ask user for passphrase before starting trezor sign-in and pass it through the existing wallet password field. - Alternative 2: SDK consumers use device-specific managers (e.g. sdk.trezor.sendPassphrase). Commits: * Use TrezorWalletManager in example bloc * refactor(trezor,auth): move trezor auth into komodo_defi_local_auth * refactor: implement coderabbitai suggestions * refactor(trezor): migrate auth options and state models to freezed (#90) * migrate models to freezed * fix(types): revert changes to seed_node and auth_options commit b863ccb Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Tue Jun 24 17:40:41 2025 +0200 fix(auth): allow custom seeds for legacy wallets (#95) commit 3e9f73c Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 23 15:32:19 2025 +0200 chore: re-generate melos configs commit 1a4ec66 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 23 15:31:36 2025 +0200 fix: remove obsolete coins transformer Remove ETH coins config transformer which was temporarily required because of a breaking ETH change in KDF. commit 58acbc2 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 23 15:21:36 2025 +0200 bug: fix missing pubkey equality operators commit d05c13b Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 23 15:19:50 2025 +0200 chore: update KDF to release preview version commit fdeb713 Author: dragonhound <35845239+smk762@users.noreply.github.com> Date: Wed Jun 18 20:38:33 2025 +0800 removes BCH from _filteredCoins (#83) commit a36357e Author: Francois <takenagain@users.noreply.github.com> Date: Wed Jun 18 14:38:12 2025 +0200 feat(ui): add AssetLogo widget (#78) * Use AssetLogo in example and tweak imports * style: match the styling with the existing komodo-wallet implementation commit 8990c9c Author: DeckerSU <support@decker.su> Date: Wed Jun 18 14:37:22 2025 +0200 fix KDF not found warnings in _tryRenameFile of FetchDefiApiStep (#76) If the KDF binaries were already renamed from `mm2` to `kdf`—i.e., if the target folder already contained `kdf.exe` or `libkdf.a` after the last successful rename from `*mm2*`—the warning `KDF not found at` would still appear, which was a bit confusing. Now, if the folder already contains the renamed binary, the warning no longer appears. commit 55176e1 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Mon Jun 16 01:02:04 2025 +0200 fix: revert ETH coins config migration transformer commit 7d438bd Author: Francois <takenagain@users.noreply.github.com> Date: Sun Jun 15 17:31:26 2025 +0200 fix(kdf): enable p2p in noAuth mode (#86) * fix(kdf): enable p2p in noAuth mode * refactor(kdf): use SeedNodeService to get seednodes for noAuth commit 4038b86 Author: CharlVS <77973576+CharlVS@users.noreply.github.com> Date: Sun Jun 15 02:15:36 2025 +0200 chore: refresh KDF checksums commit aa8148b Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Sun Jun 15 00:17:09 2025 +0200 feat: add configurable seed node system with remote fetching (#85) * feat: add custom seed nodes - Add custom seed nodes to accommodate breaking KDF changes. - Upgrade KDF for latest seed node changes. * feat: add configurable seed node system with remote fetching Implement a comprehensive seed node configuration system that fetches seed nodes from the Komodo Platform repository with automatic fallback to hardcoded defaults. ### New Features: - Add SeedNode and SeedNodeContact types for type-safe configuration - Implement SeedNodeUpdater for fetching remote seed nodes - Add SeedNodeService with automatic fallback mechanism - Add SeedNodeValidator with enhanced P2P configuration validation - Export seed node service from komodo_defi_framework ### Configuration Updates: - Update build_config.json to include seed-nodes.json mapping - Add seed_nodes.json to gitignore for dynamic assets - Change API branch from 'dev' to 'alt-main' - Update all platform binary checksums and commit hashes ### Framework Integration: - Add automatic seed node fetching to KdfStartupConfig - Integrate SeedNodeService into auth service for wallet creation - Fix trading protocol parameter name (trading_proto_v2 -> use_trading_proto_v2) - Improve boolean validation in SeedNodeValidator ### Documentation: - Add comprehensive SEED_NODES_GUIDE.md with usage examples - Include example code for seed node functionality - Add complete test coverage for new types and services ### Dependencies: - Add komodo_coin_updates dependency to komodo_defi_framework - Export seed node types from komodo_defi_types - Update pubspec.lock files across packages The seed node system ensures applications always have access to current seed nodes while maintaining backwards compatibility through fallback mechanisms. This addresses the upcoming requirement in v2.5.0-beta where seed nodes will be mandatory unless P2P is disabled. Breaking changes: None - all changes are additive with sensible defaults. * chore: PR cleanup commit 2768355 Author: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Date: Tue Jun 10 16:34:01 2025 +0200 chore(android): downgrade Java compatibility from 21 to 17 (#79) Co-authored-by: DeckerSU <deckersu@protonmail.com> commit f63bebb Author: Francois <takenagain@users.noreply.github.com> Date: Fri Jun 6 13:46:17 2025 +0200 fix(trezor,activation): add PrivateKeyPolicy to AuthOptions (#75) * fix(trezor,activation): add PrivateKeyPolicy to AuthOptions and beyond * refactor(types): replace `.from` with `.of` of has type annotations Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> --------- Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> commit 040c040 Author: dragonhound <35845239+smk762@users.noreply.github.com> Date: Fri Jun 6 19:20:28 2025 +0800 Update/ethscan v2 (#71) * update etherscan-proxy to v2 * add distinct token url paths
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrivateKeyPolicyfeat(asset-manager): asset filter strategy based on current wallet #107komodo_defi_frameworkto match the version used in build_transformer and local_auth: v1.3.0. No dependency changes.Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation