fix(market-data-price): try fetch current price from komodo price repository first before cex repository

[takenagain]

Attempts to get current USD price first from KomodoPriceRepository and then from CexRepository.

Before

After

Summary by CodeRabbit

• New Features

  • Introduced a fallback mechanism for price retrieval, prioritizing the Komodo price source when available and falling back to the existing provider if needed.

• Bug Fixes

  • Improved error handling and caching for more reliable and accurate price fetching.

[coderabbitai]

Walkthrough

A fallback mechanism for price retrieval was added to CexMarketDataManager. New private methods determine if the Komodo repository can be used, attempt to fetch prices from it, and centralize fallback logic. The main price-fetching methods now use this logic, improving cache handling and error management without altering public interfaces.

Changes

Cohort / File(s)	Change Summary
CexMarketDataManager Fallback Logic packages/komodo_defi_sdk/lib/src/market_data/market_data_manager.dart	Added private methods for Komodo repository fallback, updated price retrieval logic, improved caching, and refined error handling. No public API changes.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CexMarketDataManager
    participant KomodoRepository
    participant CexRepository

    Client->>CexMarketDataManager: Request fiatPrice or maybeFiatPrice
    CexMarketDataManager->>CexMarketDataManager: Check cache
    alt Price in cache
        CexMarketDataManager-->>Client: Return cached price
    else Price not in cache
        CexMarketDataManager->>CexMarketDataManager: _canUseKomodoRepository?
        alt Can use Komodo
            CexMarketDataManager->>KomodoRepository: Try fetch price
            alt Komodo returns price
                CexMarketDataManager->>CexMarketDataManager: Cache price
                CexMarketDataManager-->>Client: Return Komodo price
            else Komodo fails
                CexMarketDataManager->>CexRepository: Try fetch price
                alt CEX returns price
                    CexMarketDataManager->>CexMarketDataManager: Cache price
                    CexMarketDataManager-->>Client: Return CEX price
                else CEX fails
                    CexMarketDataManager-->>Client: Return null or throw error
                end
            end
        else Cannot use Komodo
            CexMarketDataManager->>CexRepository: Try fetch price
            alt CEX returns price
                CexMarketDataManager->>CexMarketDataManager: Cache price
                CexMarketDataManager-->>Client: Return CEX price
            else CEX fails
                CexMarketDataManager-->>Client: Return null or throw error
            end
        end
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

In the meadow where prices hop and play,
A Komodo fallback now leads the way.
If one stream dries, another flows—
The clever manager always knows!
With caches tucked and errors few,
This bunny brings fresh value to you.
🐇💸

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db2a5fc and 7d5b948.

📒 Files selected for processing (1)

• packages/komodo_defi_sdk/lib/src/market_data/market_data_manager.dart (5 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: legacy rpc methods in the komodo defi sdk (located in `/legacy/` subdirectories) intentionally use `...

Learnt from: takenagain
PR: KomodoPlatform/komodo-defi-sdk-flutter#70
File: packages/komodo_defi_rpc_methods/lib/src/rpc_methods/swaps/legacy/cancel_order.dart:8-9
Timestamp: 2025-06-02T12:44:56.953Z
Learning: Legacy RPC methods in the Komodo DeFi SDK (located in `/legacy/` subdirectories) intentionally use `mmrpc: null` in their constructors, unlike modern RPC methods that use `mmrpc: "2.0"`. This is by design and should not be changed to maintain backward compatibility.

Applied to files:

• packages/komodo_defi_sdk/lib/src/market_data/market_data_manager.dart

📚 Learning: in the komodo defi rpc methods codebase, input validation is performed in the request model classes ...

Learnt from: takenagain
PR: KomodoPlatform/komodo-defi-sdk-flutter#70
File: packages/komodo_defi_rpc_methods/lib/src/rpc_methods/swaps/swap_methods_namespace.dart:181-214
Timestamp: 2025-07-09T08:07:11.651Z
Learning: In the Komodo DeFi RPC methods codebase, input validation is performed in the request model classes (like SetPriceRequest, BuyRequest, etc.) rather than in the namespace methods. This centralized validation approach avoids code duplication and ensures validation occurs regardless of how request objects are instantiated.

Applied to files:

• packages/komodo_defi_sdk/lib/src/market_data/market_data_manager.dart

🔇 Additional comments (7)

packages/komodo_defi_sdk/lib/src/market_data/market_data_manager.dart (7)

3-3: Good addition for logging support.

The dart:developer import enables proper logging functionality used in the new error handling code.

---

131-141: Well-designed constraint validation method.

The method correctly validates the constraints for using Komodo repository - only current prices (no historical dates) and only USD/USDT currencies. The implementation is clear and follows the documented limitations.

---

143-160: Proper error handling and fallback implementation.

The method correctly handles errors with logging (addressing previous review feedback) and gracefully returns null on failure. The price parsing using Decimal.parse() is appropriate for financial calculations.

---

162-196: Excellent fallback mechanism implementation.

This method implements the core PR objective perfectly - it tries Komodo repository first when applicable, then falls back to CEX repository. The error handling is comprehensive with proper logging, and the method returns null instead of throwing exceptions to allow graceful handling upstream.

---

214-215: Simplified cache-only logic is correct.

The method now focuses solely on returning cached values, which aligns with its synchronous nature and the comment about not being able to fetch from repositories.

---

241-254: Proper integration of fallback mechanism.

The method correctly uses the new _getPriceWithFallback method and handles the nullable return appropriately by throwing a StateError when no price is available, which maintains the contract of this method to always return a price or throw.

---

277-301: Smart early return optimization with proper fallback logic.

The logic correctly checks if either the Komodo repository can be used OR the ticker is known in CEX before attempting to fetch. This prevents unnecessary network calls when neither source can provide the data. The fallback mechanism is properly integrated with caching.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/market-data-price

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Visit the preview URL for this PR (updated for commit db2a5fc):

https://komodo-defi-sdk--pr167-bugfix-market-data-p-o8cezkkm.web.app

_{(expires Fri, 08 Aug 2025 15:10:17 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347}

[takenagain]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[takenagain]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[Copilot]

Pull Request Overview

This PR introduces a fallback mechanism for cryptocurrency price fetching by prioritizing the Komodo price repository over the CEX repository when appropriate conditions are met.

• Adds logic to attempt fetching current USD/USDT prices from KomodoPriceRepository first
• Falls back to the existing CexRepository if Komodo repository fails or doesn't support the request
• Improves error handling and maintains existing caching behavior

[CharlVS]

LGTM TGIF

Nice concise solution.