feat(pubkey-banning): expirable bans

[onur-ozkan]

Implements expirable public key banning. For swaps public keys will be banned for one hour, which should be a sufficient penalty (and can be easily increased if needed). Manual bans will default to permanent but this can be changed by including the duration_min parameter in the request.

Fixes #1985

Docs issue: GLEECBTC/komodo-docs-mdx#491

[mariocynicys]

neat!
looks good other than the small bound on ban duration via rpc.

[BigFish2086]

only bumping the version of timed-map on my side causes another changes in the Cargo.lock file in the signature carte version, for some reason cargo changed its version and it started using signature 2.2.0 that caused the following error:

error[E0405]: cannot find trait `Signature` in crate `signature`
   --> /home/bigfish/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ed25519-1.5.2/src/lib.rs:335:17
    |
335 | impl signature::Signature for Signature {
    |                 ^^^^^^^^^ not found in `signature`

For more information about this error, try `rustc --explain E0405`.
error: could not compile `ed25519` (lib) due to previous error

Cargo.lock Diff

@@ -1125,7 +1125,7 @@ dependencies = [
"rand_core 0.6.4",
"serde",
"serde_json",
- "signature 2.2.0",
+ "signature",
"subtle-encoding",
"tendermint",
"thiserror",
@@ -1680,7 +1680,7 @@ dependencies = [
"digest 0.10.7",
"elliptic-curve",
"rfc6979",
- "signature 2.2.0",
+ "signature",
"spki",
]

@@ -1691,7 +1691,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1e9c280362032ea4203659fc489832d0204ef09f247a0506f170dafcac08c369"
dependencies = [
"serde",
- "signature 1.4.0",
+ "signature",
]

[[package]]
@@ -1701,7 +1701,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "115531babc129696a58c64a4fef0a8bf9e9698629fb97e9e40767d235cfbcd53"
dependencies = [
"pkcs8",
- "signature 2.2.0",
+ "signature",
]

[[package]]
@@ -6326,12 +6326,6 @@ dependencies = [
"libc",
]

-[[package]]
-name = "signature"
-version = "1.4.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "02658e48d89f2bec991f9a78e69cfa4c316f8d6a6c4ec12fae1aeb263d486788"
-
[[package]]
name = "signature"
version = "2.2.0"
@@ -6807,7 +6801,7 @@ dependencies = [
"serde_json",
"serde_repr",
"sha2 0.10.7",
- "signature 2.2.0",
+ "signature",
"subtle",
"subtle-encoding",
"tendermint-proto",
@@ -6969,11 +6963,12 @@ dependencies = [

[[package]]
name = "timed-map"
-version = "1.3.1"
+version = "1.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "07be2341cfbd1b8b9a84eb9212476ea383ef5cddeb85fa3ef89dc66666196619"
+checksum = "ac74a5331850dc3b08de854b57674af757b6e286e7ef930baf71e0a196f53790"
dependencies = [
"rustc-hash",
+ "serde",
"web-time",
]

So, I wonder how you solved it? or it's only a problem on my side!

[onur-ozkan]

Cargo.lock usually requires manual editing on our project, unfortunately.

[borngraced]

git checkout Cargo.lock and try compiling again.

last resort(revert signature update):
cargo update -p signature@2.2.0 --precise 1.4.0

cc. @BigFish2086

[BigFish2086]

Running git checkout Cargo.lock and compiling gave the same error.

And the second command, cargo update -p signature@2.2.0 --precise 1.4.0, shows different error message:

error: failed to select a version for the requirement `signature = "^2"`
candidate versions found which didn't match: 1.4.0
location searched: crates.io index
required by package `cosmrs v0.16.0`
    ... which satisfies dependency `cosmrs = "^0.16"` (locked to 0.16.0) of package `coins v0.1.0 (/home/bigfish/wsp/kdf/komodo/mm2src/coins)`
    ... which satisfies path dependency `coins` (locked to 0.1.0) of package `coins_activation v0.1.0 (/home/bigfish/wsp/kdf/komodo/mm2src/coins_activation)`
perhaps a crate was updated and forgotten to be re-vendored?

can it just be a cargo problem?

[borngraced]

Ah, I think rebasing on latest dev should work

• git checkout Cargo.lock to its original state
• remove the package you upgrade which I assume is timed-map
• rebase your branch with on dev

[mariocynicys]

try cargo cleaning after checking out Cargo.lock

[onur-ozkan]

I thought you were manually updating the packages. If you just want to build/test this branch, do this:

git reset --hard de6816dc406f4d6ebbf9d88103dd94e0bc60c2a3`

which will revoke and delete everything you have and make it synced with the latest commit in this PR.

[mariocynicys]

If you just want to build/test this branch

nah. he was working on the same feat in parallel but faced this issue when he tried to bump timed map. not related to testing PR.

[mariocynicys]

Thanks! LGTM!

[smk762]

@onur-ozkan While testing this, I encountered some cases in where a ban does not expire until another pubkey is banned.

To replicate:

• ban a pubkey for 1 minute

{
    "userpass": "{{userpass}}",
    "method": "ban_pubkey",
    "pubkey": "15d9c51c657ab1be4ae9d3ab6e76a619d3bccfe830d5363fa168424c0d044732",
    "reason": "1 duration_min test @ 0901",
    "duration_min": 1
  }

• wait 10 mins
• call list_banned_pubkeys
• see original pubkey is still banned in list_banned_pubkeys response.
• ban a second pubkey
• see original pubkey is no longer in list_banned_pubkeys response.

This occurs both when the second pubkey includes the duration_min param and when it does not.

I'll convert this to an issue as the PR has been merged. Docs PR can still be reviewed as the instructions should not change when this bug is squashed.