Skip to content

chore(deps): remove base58 dep#2427

Merged
shamardy merged 2 commits intodevfrom
remove-base58-dep
May 12, 2025
Merged

chore(deps): remove base58 dep#2427
shamardy merged 2 commits intodevfrom
remove-base58-dep

Conversation

@shamardy
Copy link
Copy Markdown
Collaborator

@shamardy shamardy commented Apr 25, 2025

And replace it with the more actively maintained bs58 which we already have in our dep tree.

@shamardy shamardy force-pushed the remove-base58-dep branch from f7245f8 to afb2b2c Compare April 25, 2025 01:57
@shamardy shamardy mentioned this pull request Apr 28, 2025
Merged
3 tasks
borngraced
borngraced reviewed Apr 28, 2025
View reviewed changes
Copy link
Copy Markdown

@borngraced borngraced left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good opportunity to start using [workspace.dependencies].

This will also help us avoid having deps with different version unnecessarily and ultimately will help with compile time if we eliminates unintentional deps with different version across our codebase

in root Cargo.toml

[workspace.dependencies]
bs58 = "0.4.0"

in every member crates(e.g coins, mm2_bitcoin) that needs to use this crate we can include this way

[dependencies]
bs58.workspace = true

@borngraced
Copy link
Copy Markdown

borngraced commented Apr 28, 2025

This seems like a good opportunity to start using [workspace.dependencies].

This will also help us avoid having deps with different version unnecessarily and ultimately will help with compile time if we eliminates unintentional deps with different version across our codebase

in root Cargo.toml

[workspace.dependencies]
bs58 = "0.4.0"

in every member crates(e.g coins, mm2_bitcoin) that needs to use this crate we can include this way

[dependencies]
bs58.workspace = true

I actually have a playground branch where I'm replacing some of these deps locally btw.

mariocynicys
mariocynicys previously approved these changes Apr 28, 2025
View reviewed changes
borngraced
borngraced previously approved these changes Apr 30, 2025
View reviewed changes
onur-ozkan
onur-ozkan reviewed Apr 30, 2025
View reviewed changes
mm2src/mm2_bitcoin/keys/src/lib.rs
extern crate base58;
extern crate bech32;
extern crate bitcrypto as crypto;
extern crate bs58;
Copy link
Copy Markdown

@onur-ozkan onur-ozkan Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed, we can also replace all the extern crate lines from this module, they are all rely on very old API from rustc.

Copy link
Copy Markdown
Collaborator Author

@shamardy shamardy May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned out to be a big diff, let's do it in a different PR after the toolchain update is merged.

onur-ozkan
onur-ozkan previously approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamardy shamardy mentioned this pull request May 12, 2025
Closed
@shamardy shamardy dismissed stale reviews from onur-ozkan, borngraced, and mariocynicys via a540546 May 12, 2025 20:09
@shamardy shamardy merged commit c1140d0 into dev May 12, 2025
20 of 24 checks passed
@shamardy shamardy deleted the remove-base58-dep branch May 12, 2025 21:54
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request May 13, 2025
Merge branch 'dev' into fix-utxo-tx-fee-no-doge
864b5b0 
* dev: (26 commits)
  chore(deps): remove base58 and replace it completely with bs58 (GLEECBTC#2427)
  feat(tron): initial groundwork for full TRON integration (GLEECBTC#2425)
  fix(UTXO): improve tx fee calculation and min relay fee handling (GLEECBTC#2316)
  deps(timed-map): bump to 1.3.1 (GLEECBTC#2413)
  improvement(tendermint): safer IBC channel handler (GLEECBTC#2298)
  chore(release): complete v2.4.0-beta changelogs  (GLEECBTC#2436)
  fix(event-streaming): initial addresses registration in utxo balance streaming (GLEECBTC#2431)
  improvement(watchers): re-write use-watchers handling (GLEECBTC#2430)
  fix(evm): make withdraw_nft work in HD mode (GLEECBTC#2424)
  feat(taproot): support parsing taproot output address types
  chore(RPC): use consistent param name for QTUM delegation (GLEECBTC#2419)
  fix(makerbot): add LiveCoinWatch price provider (GLEECBTC#2416)
  chore(release): add changelog entries for v2.4.0-beta (GLEECBTC#2415)
  fix(wallets): prevent path traversal in `wallet_file_path` and update file extension (GLEECBTC#2400)
  fix(nft): make `update_nft` work with hd wallets using the enabled address (GLEECBTC#2386)
  fix(wasm): unify error handling for mm2_main (GLEECBTC#2389)
  fix(tx-history): token information and query (GLEECBTC#2404)
  test(electrums): fix failing test_one_unavailable_electrum_proto_version (GLEECBTC#2412)
  improvement(network): remove static IPs from seed lists (GLEECBTC#2407)
  improvement(best-orders): return an rpc error when we can't find best orders (GLEECBTC#2318)
  ...
dimxy pushed a commit that referenced this pull request May 28, 2025
Merge branch 'dev' into lr-swap-wip
d05697c 
* dev: (29 commits)
  fix(p2pk): validate expected pubkey correctly for p2pk inputs (#2408)
  chore(docs): update old urls referencing atomicdex or old docs pages (#2428)
  improvement(p2p): remove hardcoded seeds (#2439)
  fix(evm-api): find enabled erc20 token using platform ticker (#2445)
  chore(docs): add DeepWiki badge to README (#2463)
  chore(core): organize deps using workspace.dependencies (#2449)
  feat(db-arch): more dbdir to address_dir replacements (#2398)
  chore(build-artifacts): remove duplicated mm2 build artifacts (#2448)
  feat(pubkey-banning): expirable bans (#2455)
  fix(eth-balance-events): serialize eth address using AddrToString (#2440)
  chore(deps): remove base58 and replace it completely with bs58 (#2427)
  feat(tron): initial groundwork for full TRON integration (#2425)
  fix(UTXO): improve tx fee calculation and min relay fee handling (#2316)
  deps(timed-map): bump to 1.3.1 (#2413)
  improvement(tendermint): safer IBC channel handler (#2298)
  chore(release): complete v2.4.0-beta changelogs  (#2436)
  fix(event-streaming): initial addresses registration in utxo balance streaming (#2431)
  improvement(watchers): re-write use-watchers handling (#2430)
  fix(evm): make withdraw_nft work in HD mode (#2424)
  feat(taproot): support parsing taproot output address types
  ...
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Jun 8, 2025
Merge branch 'lr-swap-wip' into lr-swap-wip-2
9260f05 
* lr-swap-wip: (37 commits)
  fix custom token error name
  fix getting chain_id from protocol_data
  refactor (review): use dedicated large error cfg, add new fn to FromApiValueError, fix TODO, use experimental namespace for lr rpc, more Ticker alias
  feat(walletconnect): add WalletConnect v2 support for EVM and Cosmos (GLEECBTC#2223)
  feat(ibc-routing-part-1): supporting entire Cosmos network for swaps (GLEECBTC#2459)
  fix(test): fix HD Wallet message signing tests (GLEECBTC#2474)
  improvement(builds): enable static CRT linking for MSVC builds (GLEECBTC#2464)
  feat(wallet): implement HD multi-address support for message signing (GLEECBTC#2432)
  fix(p2pk): validate expected pubkey correctly for p2pk inputs (GLEECBTC#2408)
  chore(docs): update old urls referencing atomicdex or old docs pages (GLEECBTC#2428)
  improvement(p2p): remove hardcoded seeds (GLEECBTC#2439)
  fix(evm-api): find enabled erc20 token using platform ticker (GLEECBTC#2445)
  chore(docs): add DeepWiki badge to README (GLEECBTC#2463)
  chore(core): organize deps using workspace.dependencies (GLEECBTC#2449)
  feat(db-arch): more dbdir to address_dir replacements (GLEECBTC#2398)
  chore(build-artifacts): remove duplicated mm2 build artifacts (GLEECBTC#2448)
  feat(pubkey-banning): expirable bans (GLEECBTC#2455)
  fix(eth-balance-events): serialize eth address using AddrToString (GLEECBTC#2440)
  chore(deps): remove base58 and replace it completely with bs58 (GLEECBTC#2427)
  feat(tron): initial groundwork for full TRON integration (GLEECBTC#2425)
  ...
@shamardy shamardy mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariocynicys mariocynicys mariocynicys left review comments

+2 more reviewers

@onur-ozkan onur-ozkan onur-ozkan left review comments

@borngraced borngraced borngraced left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: pending review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shamardy @borngraced @onur-ozkan @mariocynicys