Adds min_duration to ban_pubkey KDF method#507
Merged
Conversation
smk762
requested review from
AndrewDelaney,
CharlVS,
ShantanuSharma9873,
gcharang and
onur-ozkan
smk762
added
P1
|
Preview for merge commit: de57002, available on cloudflare at: https://ad85f0c5.komodo-docs.pages.dev/en/docs/ |
Documentation Preview LinksPreview for commit: a6b8303 |
CharlVS
approved these changes
Jun 5, 2025
CharlVS
left a comment
CharlVS
left a comment
There was a problem hiding this comment.
RPC isn't currently implemented in KW/SDK, so no changes needed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #491
Related KDF PR: GLEECBTC/komodo-defi-framework#2455
Note: An issue has been filed related to this update. Testing of this PR should await resolution of this issue.