Skip to content

chore(RPC): use consistent param name for QTUM delegation#2419

Merged
shamardy merged 2 commits intodevfrom
qtum-delegate-address-param
Apr 22, 2025
Merged

chore(RPC): use consistent param name for QTUM delegation#2419
shamardy merged 2 commits intodevfrom
qtum-delegate-address-param

Conversation

@onur-ozkan
Copy link
Copy Markdown

Addressing GLEECBTC/komodo-docs-mdx#428 (comment). I think it's fine to not accept address anymore as this RPC uses experimental prefix, but I can also do that if you think otherwise.

cc @smk762

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@shamardy
Copy link
Copy Markdown
Collaborator

I will fix the small compilation error

@shamardy shamardy requested a review from smk762 April 21, 2025 22:53
Copy link
Copy Markdown

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shamardy shamardy merged commit 1635690 into dev Apr 22, 2025
24 of 25 checks passed
@shamardy shamardy deleted the qtum-delegate-address-param branch April 22, 2025 19:14
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request May 13, 2025
* dev: (26 commits)
  chore(deps): remove base58 and replace it completely with bs58 (GLEECBTC#2427)
  feat(tron): initial groundwork for full TRON integration (GLEECBTC#2425)
  fix(UTXO): improve tx fee calculation and min relay fee handling (GLEECBTC#2316)
  deps(timed-map): bump to 1.3.1 (GLEECBTC#2413)
  improvement(tendermint): safer IBC channel handler (GLEECBTC#2298)
  chore(release): complete v2.4.0-beta changelogs  (GLEECBTC#2436)
  fix(event-streaming): initial addresses registration in utxo balance streaming (GLEECBTC#2431)
  improvement(watchers): re-write use-watchers handling (GLEECBTC#2430)
  fix(evm): make withdraw_nft work in HD mode (GLEECBTC#2424)
  feat(taproot): support parsing taproot output address types
  chore(RPC): use consistent param name for QTUM delegation (GLEECBTC#2419)
  fix(makerbot): add LiveCoinWatch price provider (GLEECBTC#2416)
  chore(release): add changelog entries for v2.4.0-beta (GLEECBTC#2415)
  fix(wallets): prevent path traversal in `wallet_file_path` and update file extension (GLEECBTC#2400)
  fix(nft): make `update_nft` work with hd wallets using the enabled address (GLEECBTC#2386)
  fix(wasm): unify error handling for mm2_main (GLEECBTC#2389)
  fix(tx-history): token information and query (GLEECBTC#2404)
  test(electrums): fix failing test_one_unavailable_electrum_proto_version (GLEECBTC#2412)
  improvement(network): remove static IPs from seed lists (GLEECBTC#2407)
  improvement(best-orders): return an rpc error when we can't find best orders (GLEECBTC#2318)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants