Skip to content

use latest KDF commit on sia-rc-cleanup#3398

Merged
smk762 merged 18 commits intodevfrom
test-sia
Nov 23, 2025
Merged

use latest KDF commit on sia-rc-cleanup#3398
smk762 merged 18 commits intodevfrom
test-sia

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Nov 17, 2025

PR for CI builds to test SIA integration.
Please add any problems or missing functionality to #3399

Confirmed the following issues have been resolved:

  • incomplete transaction history display
  • No SIA option in filter
  • Bypass SIA privkey export error gracefully
  • SIA withdraw method and raw transaction broadcast tweaks.
  • KDF side maker bug causing swap fails
  • KDF side bestorders SIA display bug

Note

Moves coins manager filtering to SDK CoinSubClass, executes withdrawals via SDK progress API, and adds Sia plus tx_json support in requests/models.

  • Coins Manager (UI/State)
    • Switch filter model from legacy CoinType to SDK CoinSubClass across events, state, bloc logic, and UI components.
    • Build filter options dynamically from coins’ id.subClass; filtering now matches coin.id.subClass.
  • Withdrawals
    • Replace direct MM2 send_raw_transaction broadcast with _sdk.withdrawals.executeWithdrawal(...) progress stream; remove unused Mm2Api field.
  • MM2 API & Models
    • SendRawTransactionRequest: allow either tx_hex or tx_json (both optional but one required).
    • WithdrawDetails: accept optional txHex/txJson with assertion; parsing updated accordingly.
  • Protocol/Coin Types
    • Add Sia mapping between CoinSubClass and legacy CoinType, including name/color and history/explorer handling.
  • KMD Rewards
    • Validate txHex presence before broadcasting.

Written by Cursor Bugbot for commit 57ece57. This will update automatically on new commits. Configure here.

@smk762 smk762 self-assigned this Nov 17, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test-sia

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 17, 2025

Visit the preview URL for this PR (updated for commit 200fbfb):

https://walletrc--pull-3398-merge-hmg68our.web.app

(expires Sun, 30 Nov 2025 07:33:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@smk762 smk762 mentioned this pull request Nov 17, 2025
@smk762 smk762 marked this pull request as draft November 17, 2025 10:24
@takenagain
Copy link
Copy Markdown
Contributor

takenagain commented Nov 21, 2025

Regression noticed in this PR: Tendermint token icons appear incorrect - all protocol icons are ATOM.

image

@smk762 smk762 marked this pull request as ready for review November 23, 2025 08:10
@smk762 smk762 merged commit 3bb9486 into dev Nov 23, 2025
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants