fix single tx history display for SIA coins

[smk762]

Fixes bug where only a single tx entry would appear in SIA coin page tx history.

• Added a _txKey helper in transaction_history_bloc.dart that falls back to txHash/id when internalId is empty, ensuring Sia transactions receive unique keys even though MM2 returns "" for internal_id.
• Updated all in-memory maps (byId, _firstSeenAtById, _processedTxIds) to use _txKey(...) so batches no longer overwrite each other when internal_id is blank, letting every SC transaction display.

To test:

• login to a wallet which has more than one SC transaction in its history
• activate SC
• go to SC page
• confirm tx history is complete, and not redacted after a single entry

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/sia-tx-history

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

https://github.com/KomodoPlatform/komodo-wallet/blob/9dff1144db3e215d834c6fc8f7b833c6d6cec031/lib/bloc/transaction_history/transaction_history_bloc.dart#L111-L114
Update existing transaction using wrong key

After switching the in‑memory map to use _txKey so Sia transactions can be keyed by txHash or id instead of the empty internalId, the merge logic still writes back with byId[sanitized.internalId] = .... When internalId is blank (the case this commit targets), existing is read from byId[txKey] but the update is stored under the empty string, leaving the original entry untouched and adding a duplicate value. Subsequent batches that refresh confirmations will keep showing the stale copy keyed by txHash, while the latest data sits under '', so users may see duplicated transactions or confirmations that never advance. The update should use the same txKey that was used to look up the existing entry.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[mariocynicys]

is this deployed somewhere?

[takenagain]

This was resolved in KDF #2691, and SC/SCZEN transactions appear as expected for me in #3398 (once confirmed). I believe this PR can be closed, leaving internal_id as a unique identifier for transactions in the wallet and the SDK (luckily only one reference in each, so changing this behaviour is doable).

[takenagain]

is this deployed somewhere?

Deployments only run for PRs into specified branch prefixes, like dev in the base PR #3398, so there is unfortunately no preview link available for this PR.

[smk762]

This was resolved in KDF #2691, and SC/SCZEN transactions appear as expected for me in #3398 (once confirmed). I believe this PR can be closed, leaving internal_id as a unique identifier for transactions in the wallet and the SDK (luckily only one reference in each, so changing this behaviour is doable).

confirmed, closing