Skip to content

adds SIA filter to activation menu#3402

Closed
smk762 wants to merge 1 commit intotest-siafrom
add-sia-filter
Closed

adds SIA filter to activation menu#3402
smk762 wants to merge 1 commit intotest-siafrom
add-sia-filter

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Nov 19, 2025

fixes #3399 (comment)

To test:

  • login
  • go to coin activation page
  • open filter, and confirm Sia option is present
  • click to filter for SIA
  • confirm only SC/SCZEN shown in filtered list.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-sia-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@takenagain takenagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharlVS was this resolved in #3398 (ad6ea4c and 57ece57)? SIA is an option for me in #3398, along a few previously missing types, and works as described in this PR. If so, then I believe that this PR can be closed in favour of those commits.

@smk762
Copy link
Copy Markdown
Collaborator Author

smk762 commented Nov 23, 2025

@CharlVS was this resolved in #3398 (ad6ea4c and 57ece57)? SIA is an option for me in #3398, along a few previously missing types, and works as described in this PR. If so, then I believe that this PR can be closed in favour of those commits.

Confirmed, closing.

@smk762 smk762 closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants