-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Android edge-to-edge mode #52116
Comments
Kiryl from Margelo expert agency is here 👋 As discussed here I'd like to take care of that 🙌 |
👋 I can do it. I'm the author of react-native-edge-to-edge, knows the subject perfectly. EDIT: Oops, just saw @kirillzyusko response. Let me know if you need help. |
@Julesssss, @kirillzyusko Whoops! This issue is 2 days overdue. Let's get this updated quick! |
1 similar comment
@Julesssss, @kirillzyusko Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@MelvinBot not overdue, I'm planning to start working on it today 👀 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
P/S was shared here by @kirillzyusko
Problem:
The android navigation bars (bottom and top) can have a different color than the background color of the app. This happens when the app theme switches (due to change in system appearance), or when the splashscreen hides.
Solution
Trying to fix the existing code with asynchronous updates is hard, as it's almost impossible to perfectly time the update from JS to the UI thread. A 100% reliable approach would be to enable
edge-to-edge
mode on Android. It'll brings several advantages, such as:edge-to-edge
mode is enabled by default on Android 15 (there is still a way to disable it if the app is not ready to edge-to-edge` mode), but in future Android versions this approach may be totally disabled: https://developer.android.com/about/versions/15/behavior-changes-15#edge-to-edge.edge-to-edge
by default as well: Handling Android 15's edge-to-edge enforcement on React Native react-native-community/discussions-and-proposals#827.Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: