[Brealing changes] Adding support of CanOpen#97
[Brealing changes] Adding support of CanOpen#97VALERA771 wants to merge 2 commits intoExMod-Team:devfrom
[Brealing changes] Adding support of CanOpen#97Conversation
|
Heavy breaking changes |
|
I know but this adds some good functional in my opinion. So waiting for 9 (I hope that we will have a major release one day) |
|
This is something I did previously(Exiled-Team/EXILED#1787), but I ended up closing it due to the break change. The name canOpen can probably be changed, because player might be closing the door. Rather than opening it. |
|
I can't imagine better name for it. IsAllowed represents CanInteract (in compare with your pr) |
|
The problem than i have with this pr it's than it's a very huge breaking change also everyone is adapt to use IsAllowed to allow the open or closing instead of interacting it's probably sound good but i don't thinks most dev agree with this change |
|
Currently IsAllowed determines can player affect door or not (open if closed and close if opened). I want to add value to block interaction. Maybe rename CanOpen to CanInteract and make it to work how IsAllowed is working? (Just like Misaka's pr) |
yeah i thinks that the best way to deal with it since people actually use IDeniableEvent with this one just to make unable to open/close but still getting the invalid interact sound |
My PR actually does it in a more complex way which does allow more functionality. However, given it would break a bunch of plugins, I agree with Yamato that having |
|
Closing. #160 done already |
Description
Describe the changes
Replacing
IsAllowedwithCanOpenand separate their logic.What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Replacing
IsAllowedwithCanOpenand separate their logic. Users need to replace IsAllowed with CanOpen if they used IsAllowed to deny accessOther information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other