[Feature] Interacting door event#1787
[Feature] Interacting door event#1787Misaka-ZeroTwo wants to merge 28 commits intoExiled-Team:devfrom Misaka-ZeroTwo:interacting-door
Conversation
|
That will need some plugin to be rewriten to not use ev.IsAllowed = false |
That's up to the dev. It still functional the same as before(do nothing). |
|
tested with setting different |
|
Closing this PR cuz it's a breaking change, however, will reopen for next major version as it seem to be a better approach. |
you can keep it open with DoNotMerge. |
|
No IL error in 13.2 |
| { | ||
| return !(variant.GetExactState() > 0f && variant.GetExactState() < 1f); | ||
| Handlers.Player.OnInteractingDoor(ev); | ||
| if (ev.IsAllowed) |
There was a problem hiding this comment.
i am really not sure about this because mostly every plugin use this to just DeniedPermission
There was a problem hiding this comment.
and even in a breaking change update it's will be confusing for people
Reopen for the next Exiled/SL major update to prevent unnecessary breaking to plugins.
New feature: Instead of setting
ev.IsAllowed = falsewhich makes the door do nothing, a new parameter allows permission denied to be shown.ev.IsAllowed = truewill need to be changed toev.InteractionResult = DoorBeepType.InteractionAllowed