Skip to content

[Feature] Interacting door event#1787

Closed
Misaka-ZeroTwo wants to merge 28 commits intoExiled-Team:devfrom
Misaka-ZeroTwo:interacting-door
Closed

[Feature] Interacting door event#1787
Misaka-ZeroTwo wants to merge 28 commits intoExiled-Team:devfrom
Misaka-ZeroTwo:interacting-door

Conversation

@Misaka-ZeroTwo
Copy link
Copy Markdown
Contributor

@Misaka-ZeroTwo Misaka-ZeroTwo commented May 12, 2023

Reopen for the next Exiled/SL major update to prevent unnecessary breaking to plugins.
New feature: Instead of setting ev.IsAllowed = false which makes the door do nothing, a new parameter allows permission denied to be shown.
ev.IsAllowed = true will need to be changed to ev.InteractionResult = DoorBeepType.InteractionAllowed

@Misaka-ZeroTwo Misaka-ZeroTwo self-assigned this May 12, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo added enhancement New feature or request regarding-events An issue or PR targeting the Exiled Events project Fix bug labels May 12, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo added the tested This PR has been built and tested and does not cause any obvious errors. label May 13, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as ready for review May 13, 2023 08:46
@Thundermaker300 Thundermaker300 requested a review from a team May 14, 2023 18:38
@louis1706
Copy link
Copy Markdown
Member

That will need some plugin to be rewriten to not use ev.IsAllowed = false

@Misaka-ZeroTwo
Copy link
Copy Markdown
Contributor Author

That will need some plugin to be rewriten to not use ev.IsAllowed = false

That's up to the dev. It still functional the same as before(do nothing).

@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as draft May 22, 2023 15:08
@Misaka-ZeroTwo Misaka-ZeroTwo added the regarding-transpiler An issue or PR that touches or is related to a patch label May 22, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as ready for review May 22, 2023 15:14
@Misaka-ZeroTwo
Copy link
Copy Markdown
Contributor Author

tested with setting different InteractionResult, and IsAllowed. Worked as expected.

@Misaka-ZeroTwo
Copy link
Copy Markdown
Contributor Author

Closing this PR cuz it's a breaking change, however, will reopen for next major version as it seem to be a better approach.

@louis1706
Copy link
Copy Markdown
Member

Closing this PR cuz it's a breaking change, however, will reopen for next major version as it seem to be a better approach.

you can keep it open with DoNotMerge.

@Misaka-ZeroTwo Misaka-ZeroTwo reopened this Jun 1, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as draft June 1, 2023 14:58
@Misaka-ZeroTwo Misaka-ZeroTwo added Do not merge Don't merge this PR and removed tested This PR has been built and tested and does not cause any obvious errors. Fix bug labels Jun 1, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo changed the title Update Interacting door event and add new parameter [New Feature] Interacting door event Jun 2, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo changed the title [New Feature] Interacting door event [Feature] Interacting door event Jun 2, 2023
@louis1706 louis1706 added this to the Exiled 8 milestone Aug 2, 2023
@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as ready for review September 1, 2023 00:59
@Misaka-ZeroTwo
Copy link
Copy Markdown
Contributor Author

No IL error in 13.2

@Misaka-ZeroTwo Misaka-ZeroTwo removed the Do not merge Don't merge this PR label Sep 1, 2023
{
return !(variant.GetExactState() > 0f && variant.GetExactState() < 1f);
Handlers.Player.OnInteractingDoor(ev);
if (ev.IsAllowed)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am really not sure about this because mostly every plugin use this to just DeniedPermission

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and even in a breaking change update it's will be confusing for people

@louis1706 louis1706 removed this from the Exiled 8 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants