Skip to content

Added CanInteract in InteractingDoor#160

Merged
vladflotsky merged 6 commits intoExMod-Team:devfrom
Cocoa2219:dev
Nov 9, 2024
Merged

Added CanInteract in InteractingDoor#160
vladflotsky merged 6 commits intoExMod-Team:devfrom
Cocoa2219:dev

Conversation

@Cocoa2219
Copy link
Copy Markdown

@Cocoa2219 Cocoa2219 commented Oct 29, 2024

Description

Describe the changes
Added new property at InteractingDoorEventArgs, named as CanInteract

What is the current behavior? (You can also link to an open issue here)
Setting IsAllowed to false doesn’t cancel the entire event; it only prevents the door from opening.

What is the new behavior? (if this is a feature change)
Added a new property, CanInteract, to InteractingDoorEventArgs to enable complete cancellation of the event when set to false.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, because default CanInteract value is set to true. This change doesn’t modify existing functionality.

Other information:
Link to Suggestion

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Cocoa2219
Copy link
Copy Markdown
Author

If the description of this property isn’t clear, feel free to change it.

Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general suggestions that I hope you will implement

@louis1706 louis1706 requested a review from VALERA771 October 31, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants