docs(tokens): consistency pass for new component descriptions#12148
Merged
docs(tokens): consistency pass for new component descriptions#12148
Conversation
DitwanP
added
the
skip visual snapshots
Member
geospatialem
left a comment
geospatialem
left a comment
There was a problem hiding this comment.
Thanks for tackling so quick! 🐇
It looks like a few of the original text sections are in alignment with our doc pattern, can you take a closer look? 👀
Could you also update the PR's summary that describes the change, rather than the action of the PR? Something like "Updates design token documentation to xyz.. components"?
geospatialem
approved these changes
May 15, 2025
Member
geospatialem
left a comment
geospatialem
left a comment
There was a problem hiding this comment.
Awesome, thanks for the quick turnaround! It looks like one minor change, then LGTM! 🚀
…nto dit13711/cleanup-token-descriptions
benelan
added a commit
that referenced
this pull request
May 15, 2025
* origin/dev: (277 commits) docs(tokens): consistency pass for new component descriptions (#12148) build(preset): use valid TS module resolution (#12151) docs: update list of contributors (#12134) chore: drop obsolete transforms (#12136) chore: release main (#11890) (#12147) build(deps): bump @arcgis/lumina, typescript, vite, vitest (#12137) chore(preset): fix JSON import in build config (#12142) docs(panel, action): update `text-color-pressed` token descriptions (#12140) chore: release next fix(input-time-picker): invert text color on Windows when each masked input is focused (#12130) chore: release next refactor(sematic-tokens): update `--calcite-corner-radius-default` to reference correct token (#12131) feat(semantic-tokens): add `--calcite-color-text-highlight` tokens (#12068) chore: release next feat(combobox): add `selectAll` toggle property (#11721) chore: release next fix(sort-handle): allow move and reorder events to be cancelled (#12095) chore: release next feat: added spike data, heart chart, and progress bar icons (#12127) feat(text-area): Add design tokens for corner radius, shadow, footer background color (#12124) ...
| * These properties can be overridden using the component's tag as selector. | ||
| * | ||
| * @prop --calcite-tab-background-color: When `bordered`, specifies the component's background color. | ||
| * @prop --calcite-tab-background-color: When `bordered`, specifies the component's background color when `bordered`. |
Member
There was a problem hiding this comment.
@DitwanP Can you do a follow-up PR to remove the extra "when bordered" at the end of this sentence?
jcfranco
pushed a commit
that referenced
this pull request
May 29, 2025
**Related Issue:** n/a ## Summary Updates token documentation for the following components: - `input-number` - `shell-panel` - `stepper-item` - `stepper` - `tabs` - `time-picker`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
Summary
Updates token documentation for the following components:
input-numbershell-panelstepper-itemsteppertabstime-picker