fix(sort-handle): allow move and reorder events to be cancelled#12095
Merged
fix(sort-handle): allow move and reorder events to be cancelled#12095
Conversation
Member
Author
|
@jcfranco this fixes the issue. However, I noticed other |
Member
The example from the description is fine since its handling internal events. If you mean how other public handle events are non-cancellable, we have to flesh out our cancelable event story first. We've been mostly making events cancelable as needed. |
jcfranco
approved these changes
May 12, 2025
Member
jcfranco
left a comment
There was a problem hiding this comment.
Code changes LGTM! Can you add a test before merging?
| @@ -136,13 +136,13 @@ export class SortHandle extends LitElement implements InteractiveComponent { | |||
| calciteSortHandleClose = createEvent({ cancelable: false }); | |||
|
|
|||
| /** Fires when a move item has been selected. */ | |||
Member
There was a problem hiding this comment.
Side note: we should add a doc snippet for cancelable events. cc @geospatialem @DitwanP
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
**Related Issue:** #11774 ## Summary - allows events to be cancelled - This is inconsistent with the other events where the propagation is being stopped when needed - see https://github.com/Esri/calcite-design-system/blob/b1c2b56c883ea3dc59c7fbc121e364b337c12d9d/packages/calcite-components/src/components/block/block.tsx#L312-L332
Merged
benelan
added a commit
that referenced
this pull request
May 15, 2025
* origin/dev: (277 commits) docs(tokens): consistency pass for new component descriptions (#12148) build(preset): use valid TS module resolution (#12151) docs: update list of contributors (#12134) chore: drop obsolete transforms (#12136) chore: release main (#11890) (#12147) build(deps): bump @arcgis/lumina, typescript, vite, vitest (#12137) chore(preset): fix JSON import in build config (#12142) docs(panel, action): update `text-color-pressed` token descriptions (#12140) chore: release next fix(input-time-picker): invert text color on Windows when each masked input is focused (#12130) chore: release next refactor(sematic-tokens): update `--calcite-corner-radius-default` to reference correct token (#12131) feat(semantic-tokens): add `--calcite-color-text-highlight` tokens (#12068) chore: release next feat(combobox): add `selectAll` toggle property (#11721) chore: release next fix(sort-handle): allow move and reorder events to be cancelled (#12095) chore: release next feat: added spike data, heart chart, and progress bar icons (#12127) feat(text-area): Add design tokens for corner radius, shadow, footer background color (#12124) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #11774
Summary
calcite-design-system/packages/calcite-components/src/components/block/block.tsx
Lines 312 to 332 in b1c2b56