Skip to content

chore(preset): fix JSON import in build config#12142

Merged
jcfranco merged 1 commit intodevfrom
jcfranco/fix-preset-build-config
May 14, 2025
Merged

chore(preset): fix JSON import in build config#12142
jcfranco merged 1 commit intodevfrom
jcfranco/fix-preset-build-config

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented May 14, 2025

Related Issue: N/A

Summary

Fixes the following TS error:

TS1544: Named imports from a JSON file into an ECMAScript module are not allowed when module is set to Node18

Note: this also bumps module and moduleResolution to node18, which should be fine since the preset hasn't been released yet

@jcfranco jcfranco requested a review from benelan as a code owner May 14, 2025 03:22
@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label May 14, 2025
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 14, 2025
Copy link
Copy Markdown
Contributor

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 69237ea into dev May 14, 2025
16 of 17 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-preset-build-config branch May 14, 2025 14:34
benelan added a commit that referenced this pull request May 15, 2025
* origin/dev: (277 commits)
  docs(tokens): consistency pass for new component descriptions (#12148)
  build(preset): use valid TS module resolution (#12151)
  docs: update list of contributors (#12134)
  chore: drop obsolete transforms (#12136)
  chore: release main (#11890) (#12147)
  build(deps): bump @arcgis/lumina, typescript, vite, vitest (#12137)
  chore(preset): fix JSON import in build config (#12142)
  docs(panel, action): update `text-color-pressed` token descriptions (#12140)
  chore: release next
  fix(input-time-picker): invert text color on Windows when each masked input is focused (#12130)
  chore: release next
  refactor(sematic-tokens): update `--calcite-corner-radius-default` to reference correct token (#12131)
  feat(semantic-tokens): add `--calcite-color-text-highlight` tokens (#12068)
  chore: release next
  feat(combobox): add `selectAll` toggle property (#11721)
  chore: release next
  fix(sort-handle): allow move and reorder events to be cancelled (#12095)
  chore: release next
  feat: added spike data, heart chart, and progress bar icons (#12127)
  feat(text-area): Add design tokens for corner radius, shadow, footer background color (#12124)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants