Enable CircleCI#405
Conversation
The rebase from celo-tip made the celo-integration branch go back a version on`github.com/minio/minio-go/v7` from `v7.0.85` to `v7.0.84`. Additionally, the devnet configuration files ended up dropping the `participants` configurations. This commit updates the version to what it was, and re-adds the participants configurations in the devnet files.
Pre-download rust dependency of Espresso Go SDK in CI builds
Removes reliance on AltDA for Espresso integration * Allows for simultaneous usage of Espresso and an AltDA provider * Allows for immediate posting of blocks to Espresso instead of waiting for new frames on a channel * When not using an alternative DA layer, L1 now receives full batch data instead of just the commitments
…`espresso-dev-node`
* Same logic for the Espresso Streamer used in the batcher and derivation pipeline * Separate the interaction between Espresso nodes and the handling of batches * Several TODOs / improvements will be addressed in another PR.
Reduces code duplication and move more code to a separate package by making Batch a type parameter of the streamer
Note this test is flaky.
* Add wait for finality logic * Add non initialization handling * Update the logic * Improve comments and error handling * Fix build after merge * Moving the l1 finality checks inside the CheckBatch function. This reverts commit 7049ebd. * Appease the go linter for CI --------- Co-authored-by: Philippe Camacho <philippe@espressosys.com>
* Integration tests for batcher contracts * Suggestions * Lints * Workaround for allocs
* Fix registration * Add readiness * Fix enclave retries * Simplify ports
* pin to different tee commit * use updated tee contract scripts * point to latest tee contract * use proxy admin from OP repo * force ref path for proxy artifact * Point to tee contracts commit at main
* feat: Replace local streamer with espresso-streamers package * fix: use go mod * feat: use buffered streamer from espresso streamers repo * fix: use v1.0.0 package of espresso-streamers
* Add log * Add hashes * Update op-node/rollup/derive/attributes_queue.go Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Fix lint * Simplify comment, remove malformed tx log --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* Rename tee batcher * change name `activeIsTee` * update function selector for espresso batcher * update security analysis doc * delete unrelated script * espresso devnet tests use fallback & espresso terms * modify .env var names * (hopefully last references) * push new batch authenticator bindings * update espresso-streamers commit * pin to point to espresso-streamers last PR
* Make constants in batch submission logic configurable. * Define verify receipt default values as shared exported constants * Validate verify-receipt tuning flags are non-zero when Espresso is enabled * Fix integration test failures introduced by verify-receipt validation
* Move Espresso related docs to directory espresso/docs. * Remove obsolete documents.
* Fix unmarshal panic * Fix the build and add a test * Update op-node/rollup/derive/espresso_batch_test.go Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Fix syntax --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
* fix espresso file naming * last clean up + reorganize sections * fix ai comments * address nit
* add batch authenticator deployment script * add labels and warn log
|
Claude finished @shenkeyao's task in 54s —— View job Code Review: Enable CircleCI
Overall: This is a clean, focused PR that removes disabled job filters and dead workflow configuration to get CircleCI running. The changes look correct and low-risk. Changes Reviewed1. Removing These removals re-enable 2. Removing The 3. Removing the The entire VerdictLGTM. All changes are deletions of disabled/dead configuration, which is straightforward to verify. The PR achieves its goal of aligning with Celo's CircleCI settings and re-enabling the previously disabled jobs. No issues found. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up the CircleCI configuration by removing redundant filters: "false" entries from several jobs, deleting the discord context from the cannon-kona-prestate job, and removing the acceptance-tests-pr workflow along with commented-out code for flaky test reporting. I have no feedback to provide.
shenkeyao
changed the base branch from
celo-integration-rebase-16.2
to
celo-integration-rebase-16.3
shenkeyao
changed the base branch from
celo-integration-rebase-16.3
to
celo-integration-rebase-16.2
shenkeyao
changed the base branch from
celo-integration-rebase-16.2
to
celo-integration-rebase-16.3
shenkeyao
force-pushed
the
keyao/enable-circleci
branch
from
35982e7 to
32266e7
Compare
shenkeyao
merged commit 609d9a4
into
celo-integration-rebase-16.3
10 participants
Closes https://app.asana.com/1/1208976916964769/project/1209976130071762/task/1213978685944092?focus=true.
This PR:
This PR does not:
How to test this PR: